Merge pull request #28 from SHADE-DP/SP3-1-Rendering

Rendering system updates 

SH_APIed appropriate classes
Routine class for graphics created but not called via RunRoutines (Daniel needs to call this in application I believe)

SHADE_Application/premake5.lua

@@ -22,13 +22,22 @@ project "SHADE_Application"
   
   includedirs 
   {
-    "%{IncludeDir.spdlog}/include",
     "../SHADE_Engine/src",
     "src",
     "%{IncludeDir.dotnet}/include",
     "%{IncludeDir.SDL}/include",
   }
   
+  externalincludedirs
+  {
+	"%{IncludeDir.spdlog}/include",
+	"%{IncludeDir.VULKAN}/include",
+	"%{IncludeDir.VMA}/include",
+	"%{IncludeDir.VULKAN}/Source/SPIRV-Reflect"
+  }
+    
+  externalwarnings "Off"
+	
   flags
   {
   	"MultiProcessorCompile"
@@ -48,6 +57,11 @@ project "SHADE_Application"
     "%{IncludeDir.SDL}/lib",
   }
   
+  defines
+  {
+  	"NOMINMAX"
+  }
+
   disablewarnings
   {
     "4251"

SHADE_Application/src/Application/SBApplication.cpp

@@ -1,9 +1,11 @@
 #include "SBpch.h"
 #include "SBApplication.h"
+#include "ECS_Base/Managers/SHSystemManager.h"
 
+#define SHEDITOR
 #ifdef SHEDITOR
-#include "Editor/SHEditor.h"
+//#include "Editor/SHEditor.h"
-#include "Scenes/SBEditorScene.h"
+//#include "Scenes/SBEditorScene.h"
 #endif // SHEDITOR
 
 #include "Tools/SHLogger.h"
@@ -32,9 +34,17 @@ namespace Sandbox
 
     SDL_Init(SDL_INIT_VIDEO);
     window.Create(hInstance, hPrevInstance, lpCmdLine, nCmdShow);
+    SHADE::SHSystemManager::CreateSystem<SHADE::SHGraphicsSystem>();
+    SHADE::SHGraphicsSystem* graphicsSystem = static_cast<SHADE::SHGraphicsSystem*>(SHADE::SHSystemManager::GetSystem<SHADE::SHGraphicsSystem>());
+    SHADE::SHSystemManager::RegisterRoutine<SHADE::SHGraphicsSystem, SHADE::SHGraphicsSystem::SHGraphicsSystemRoutine>(1);
+
+
+    graphicsSystem->SetWindow(&window);
     SDL_CreateWindowFrom(window.GetHWND());
 
+    SHADE::SHSystemManager::Init();
 		#ifdef SHEDITOR
+    //SHADE::SHEditor::Initialize(window.GetHWND());
 		#else
 		#endif
 
@@ -44,21 +54,30 @@ namespace Sandbox
 
   void SBApplication::Update(void)
   {
+    SHADE::SHGraphicsSystem* graphicsSystem = static_cast<SHADE::SHGraphicsSystem*>(SHADE::SHSystemManager::GetSystem<SHADE::SHGraphicsSystem>());
+
     //TODO: Change true to window is open
     while (!window.WindowShouldClose())
     {
-			#ifdef SHEDITOR
+      //#ifdef SHEDITOR
-			#else
+      //SHADE::SHEditor::PreRender();
-			#endif
+      //#endif
+      graphicsSystem->BeginRender();
+      graphicsSystem->Run(1.0f);
+			//#ifdef SHEDITOR
+      //SHADE::SHEditor::PreRender();
+      //SHADE::SHEditor::Update();
+      //SHADE::SHEditor::Render();
+			//#endif
+      graphicsSystem->EndRender();
   }
   }
 
 
   void SBApplication::Exit(void)
   {
-    // Shutdown scripting
     SHADE::SHScriptEngine::Exit();
-
+    SHADE::SHSystemManager::Exit();
     SDL_DestroyWindow(sdlWindow);
 		#ifdef SHEDITOR
 		#else

SHADE_Application/src/Application/SBApplication.h

@@ -1,7 +1,8 @@
 #ifndef SB_APPLICATION_H
 #define SB_APPLICATION_H
+#include <Graphics/Windowing/SHWindow.h>
+#include "Graphics/MiddleEnd/Interface/SHGraphicsSystem.h"
 #include <SDL_video.h>
-#include "Graphics/Windowing/SHWindow.h"
 //using namespace SHADE;
 
 namespace Sandbox

SHADE_Engine/premake5.lua

@@ -15,13 +15,16 @@ project "SHADE_Engine"
     "%{prj.location}/src/**.hpp",
     "%{prj.location}/src/**.c",
     "%{prj.location}/src/**.cpp",
-    "%{prj.location}/src/**.glsl",
+    "%{prj.location}/src/**.glsl"
-    "%{wks.location}/Dependencies/stb_image/**.cpp"
   }
   
   includedirs
   {
     "%{prj.location}/src",
+  }
+  
+  externalincludedirs
+  {
 	"%{IncludeDir.assimp}/include",
     "%{IncludeDir.imgui}",
     "%{IncludeDir.imguizmo}",
@@ -40,6 +43,8 @@ project "SHADE_Engine"
     "%{IncludeDir.dotnet}/include",
   }
   
+  externalwarnings "Off"
+  
   libdirs
   {
   	"%{prj.location}/libs",

SHADE_Engine/src/ECS_Base/Managers/SHSystemManager.h

@@ -21,6 +21,7 @@
 #include "../System/SHSystem.h"
 #include "../General/SHFamily.h"
 #include "../System/SHSystemRoutine.h"
+#include "SH_API.h"
 
 namespace SHADE
 {
@@ -28,7 +29,7 @@ namespace SHADE
 
 	typedef SHFamilyID<SHSystem> SystemFamily;
 
-	class SHSystemManager
+	class SH_API SHSystemManager
 	{
 		//type definition for the container we use to store our system
 		using SystemContainer = std::map<SystemID, std::unique_ptr<SHSystem>>;

SHADE_Engine/src/Graphics/Buffers/SHVkBuffer.cpp

@@ -33,6 +33,8 @@ namespace SHADE
       };
       cmdBufferHdl->GetVkCommandBuffer().copyBuffer(stagingBuffer, vkBuffer, 1, &copyRegion);
     }
+
+    // TODO: Need to destroy staging buffer. Obviously not here but after the command has finished executing.
   }
 
   vk::Buffer SHVkBuffer::GetVkBuffer(void) const noexcept

SHADE_Engine/src/Graphics/Buffers/SHVkBuffer.h

@@ -48,7 +48,6 @@ namespace SHADE
     vk::BufferUsageFlags bufferUsageFlags;
 
     //! Reference to the allocator
-    //VmaAllocator const& vmaAllocator;
     std::reference_wrapper<VmaAllocator const> vmaAllocator;
 
     /*-----------------------------------------------------------------------*/

SHADE_Engine/src/Graphics/Commands/SHVkCommandBuffer.cpp

@@ -76,7 +76,10 @@ namespace SHADE
     // Check if command buffer is ready to record.
     if (cmdBufferState != SH_CMD_BUFFER_STATE::INITIAL)
     {
-      SHLOG_ERROR("Command buffer not in initial state, cannot begin recording. ");
+      SHLOG_ERROR("Command buffer not in initial state, cannot begin recording. Command buffer could be: \n"
+        "- corrupted and in invalid state\n"
+        "- in executable state\n"
+        "- in pending state\n");
       return;
     }
 
@@ -182,7 +185,9 @@ namespace SHADE
 
     // Check if render area is optimal 
     if (!IsRenderAreaOptimal(renderpassHdl, framebufferExtent, renderPassInfo.renderArea))
+    {
       SHLOG_ERROR("Render area in renderpass begin info is not optimal. See Vulkan vkGetRenderAreaGranularity for details.");
+    }
 
     // Begin the render pass 
     vkCommandBuffer.beginRenderPass (&renderPassInfo, vk::SubpassContents::eInline);
@@ -202,6 +207,11 @@ namespace SHADE
     vkCommandBuffer.endRenderPass();
   }
 
+  void SHVkCommandBuffer::NextSubpass(void) noexcept
+  {
+    vkCommandBuffer.nextSubpass(commandBufferType == SH_CMD_BUFFER_TYPE::PRIMARY ? vk::SubpassContents::eInline : vk::SubpassContents::eSecondaryCommandBuffers);
+  }
+
   /***************************************************************************/
   /*!
   
@@ -406,6 +416,41 @@ namespace SHADE
 
   }
 
+
+  void SHVkCommandBuffer::PipelineBarrier (
+                                           vk::PipelineStageFlags srcStage,
+                                           vk::PipelineStageFlags dstStage,
+                                           vk::DependencyFlags deps,
+                                           std::vector<vk::MemoryBarrier> const& memoryBarriers,
+                                           std::vector<vk::BufferMemoryBarrier> const& bufferMemoryBarriers,
+                                           std::vector<vk::ImageMemoryBarrier> const& imageMemoryBarriers
+                                          ) const noexcept
+  {
+    vkCommandBuffer.pipelineBarrier (
+                                     srcStage, 
+                                     dstStage, 
+                                     deps, 
+                                     memoryBarriers, 
+                                     bufferMemoryBarriers,
+                                     imageMemoryBarriers
+                                    );
+  }
+
+  bool SHVkCommandBuffer::IsReadyToSubmit(void) const noexcept
+  {
+    return cmdBufferState == SH_CMD_BUFFER_STATE::EXECUTABLE;
+  }
+
+  void SHVkCommandBuffer::HandlePostSubmit(void) noexcept
+  {
+    SetState(SH_CMD_BUFFER_STATE::PENDING);
+  }
+
+  //void SHVkCommandBuffer::PipelineBarrier(vk::PipelineStageFlags ) const noexcept
+  //{
+  //  //vkCommandBuffer.pipelineBarrier()
+  //}
+
   /***************************************************************************/
   /*!
   
@@ -463,9 +508,7 @@ namespace SHADE
   {
     vk::Extent2D granularity = parentPool->GetLogicalDevice()->GetVkLogicalDevice().getRenderAreaGranularity(renderpassHdl->GetVkRenderpass());
 
-    return (renderArea.offset.x % granularity.width == 0 && renderArea.offset.y % granularity.height == 0 &&
+    return (renderArea.offset.x % granularity.width == 0 && renderArea.offset.y % granularity.height == 0 && (renderArea.extent.width % granularity.width || renderArea.offset.x + renderArea.extent.width == framebufferExtent.width) && (renderArea.extent.height % granularity.height || renderArea.offset.y + renderArea.extent.height == framebufferExtent.height));
-           (renderArea.extent.width % granularity.width || renderArea.offset.x + renderArea.extent.width == framebufferExtent.width) &&
-           (renderArea.extent.height % granularity.height || renderArea.offset.y + renderArea.extent.height == framebufferExtent.height));
   }
 
   /***************************************************************************/
@@ -529,6 +572,7 @@ namespace SHADE
     , usageFlags{}
     , commandBufferCount{ 0 }
     , parentPool{commandPool}
+    , pushConstantData{}
 
   {
     vk::CommandBufferAllocateInfo allocateInfo{};

SHADE_Engine/src/Graphics/Commands/SHVkCommandBuffer.h

@@ -96,11 +96,12 @@ namespace SHADE
     /*-----------------------------------------------------------------------*/
     void Reset(void);
 
-    // Begins and Ends
+    // Begins, Ends and Nexts
     void BeginRecording     (void) noexcept;
     void EndRecording       (void) noexcept;
     void BeginRenderpass    (Handle<SHVkRenderpass> const& renderpassHdl, Handle<SHVkFramebuffer> const& framebufferHdl, vk::Offset2D offset = {0, 0}, vk::Extent2D extent = {0, 0}) noexcept;
     void EndRenderpass      (void) noexcept;
+    void NextSubpass        (void) noexcept;
 
     // Dynamic State
     void SetviewportScissor (float vpWidth, float vpHeight, uint32_t sWidth, uint32_t sHeight, float vpX = 0.0f, float vpY = 0.0f, int32_t sX = 0.0f, int32_t sY = 0.0f, float vpMinDepth = 0.0f, float vpMaxDepth = 1.0f) noexcept;
@@ -114,6 +115,19 @@ namespace SHADE
     void DrawArrays         (uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance) const noexcept;
     void DrawIndexed        (uint32_t indexCount, uint32_t firstIndex, uint32_t vertexOffset) const noexcept;
 
+    // memory barriers
+    void PipelineBarrier    (
+                             vk::PipelineStageFlags srcStage, 
+                             vk::PipelineStageFlags dstStage, 
+                             vk::DependencyFlags deps, 
+                             std::vector<vk::MemoryBarrier> const& memoryBarriers,
+                             std::vector<vk::BufferMemoryBarrier> const& bufferMemoryBarriers,
+                             std::vector<vk::ImageMemoryBarrier> const& imageMemoryBarriers
+                            ) const noexcept;
+
+    bool IsReadyToSubmit    (void) const noexcept;
+    void HandlePostSubmit   (void) noexcept;
+
     // Push Constant variable setting
     template <typename T>
     void SetPushConstantVariable(std::string variableName, T const& data) noexcept

SHADE_Engine/src/Graphics/Commands/SHVkCommandPool.cpp

@@ -150,20 +150,19 @@ namespace SHADE
     logicalDeviceHdl->GetVkLogicalDevice().resetCommandPool(vkCommandPool, vk::CommandPoolResetFlagBits::eReleaseResources);
     for (auto& primary : primaries)
     {
-      if (primary->GetState() != SH_CMD_BUFFER_STATE::PENDING)
+      // #NoteToSelf: Since there is no way to set the state of a command buffer back to initial, we just hard set it to initial. Ditto for secondaries.
+      //if (primary->GetState() != SH_CMD_BUFFER_STATE::PENDING)
       primary->SetState(SH_CMD_BUFFER_STATE::INITIAL);
-      else
+
-        SHLOG_ERROR("Primary command buffer in pending state, could not reset. ");
+
       // From the spec: Any primary command buffer allocated from another VkCommandPool that is in the recording or
       // executable state and has a secondary command buffer allocated from commandPool recorded into it,
       // becomes invalid. TODO: Might want to check and throw exception for these conditions after making sure this actually happens using validation layers. 
     }
     for (auto& secondary : secondaries)
     {
-      if (secondary->GetState() != SH_CMD_BUFFER_STATE::PENDING)
+      //if (secondary->GetState() != SH_CMD_BUFFER_STATE::PENDING)
       secondary->SetState(SH_CMD_BUFFER_STATE::INITIAL);
-      else
-        SHLOG_ERROR("Secondary command buffer in pending state, could not reset. ");
 
       // TODO: Ditto from TODO in primary check
     }

SHADE_Engine/src/Graphics/Debugging/SHVulkanDebugUtil.cpp

@@ -59,7 +59,7 @@ namespace SHADE
 
   */
   /***************************************************************************/
-  void SHVulkanDebugUtil::ReportVkWarning(vk::Result vkResult, std::string_view message, std::source_location const& location /*= std::source_location::current()*/) noexcept
+  void SHVulkanDebugUtil::ReportVkWarning(vk::Result vkResult, std::string_view message) noexcept
   {
     //std::cout << location.file_name() << ": " << location.function_name() << "|" << location.line() << "|" <<
     //  location.column() << "|: Warning: " << SHDebugUtil::VkResultToString(vkResult) << " | " << message << std::endl;
@@ -88,7 +88,7 @@ namespace SHADE
 
   */
   /***************************************************************************/
-  void SHVulkanDebugUtil::ReportVkError(vk::Result vkResult, std::string_view message, std::source_location const& location /*= std::source_location::current()*/) noexcept
+  void SHVulkanDebugUtil::ReportVkError(vk::Result vkResult, std::string_view message) noexcept
   {
     std::string toLogger = "Vulkan Warning: " + std::string(SHVulkanDebugUtil::VkResultToString(vkResult)) + " | " + std::string(message);
 
@@ -96,7 +96,7 @@ namespace SHADE
   }
 
 
-  void SHVulkanDebugUtil::ReportVkSuccess(std::string_view message, std::source_location const& location /*= std::source_location::current()*/) noexcept
+  void SHVulkanDebugUtil::ReportVkSuccess(std::string_view message) noexcept
   {
     SHLOGV_INFO(message);
   }

SHADE_Engine/src/Graphics/Debugging/SHVulkanDebugUtil.h

@@ -15,9 +15,9 @@ namespace SHADE
   public:
     static VKAPI_ATTR VkBool32 VKAPI_CALL GenericDebugCallback(VkDebugUtilsMessageSeverityFlagBitsEXT messageSeverity, VkDebugUtilsMessageSeverityFlagsEXT messageType, const VkDebugUtilsMessengerCallbackDataEXT* pCallbackData, void* pUserData);
 
-    static void ReportVkWarning(vk::Result vkResult, std::string_view message, std::source_location const& location = std::source_location::current()) noexcept;
+    static void ReportVkWarning(vk::Result vkResult, std::string_view message) noexcept;
-    static void ReportVkError(vk::Result vkResult, std::string_view message, std::source_location const& location = std::source_location::current()) noexcept;
+    static void ReportVkError(vk::Result vkResult, std::string_view message) noexcept;
-    static void ReportVkSuccess(std::string_view message, std::source_location const& location = std::source_location::current()) noexcept;
+    static void ReportVkSuccess(std::string_view message) noexcept;
 
   };
 

SHADE_Engine/src/Graphics/Descriptors/SHDescriptorSetUpdater.cpp

@@ -0,0 +1,84 @@
+#include "SHpch.h"
+#include "SHDescriptorSetUpdater.h"
+
+namespace SHADE
+{
+  
+  SHDescriptorWriteInfo::SHDescriptorWriteInfo(SHDescriptorWriteInfo&& rhs) noexcept
+    : descImageInfos{ std::move(rhs.descImageInfos) }
+    , descBufferInfos{ std::move(rhs.descBufferInfos) }
+    , descTexelBufferInfos{std::move (rhs.descTexelBufferInfos)}
+  {
+
+  }
+
+  SHDescriptorWriteInfo::SHDescriptorWriteInfo(void) noexcept
+    : descImageInfos{}
+    , descBufferInfos{}
+    , descTexelBufferInfos{}
+  {
+    
+  }
+
+  /***************************************************************************/
+  /*! 
+   
+    \brief
+      Links the write infos to the vulkan write descriptor sets.
+    
+  */ 
+  /***************************************************************************/
+  void SHDescriptorSetUpdater::LinkInfoToWriteDescSet(void) noexcept
+  {
+    for (uint32_t i = 0; i < writeInfos.size(); ++i)
+    {
+      writeDescSets[i].pImageInfo = writeInfos[i].descImageInfos.data();
+      writeDescSets[i].pBufferInfo = writeInfos[i].descBufferInfos.data();
+      writeDescSets[i].pTexelBufferView = writeInfos[i].descTexelBufferInfos.data();
+    }
+  }
+
+  SHDescriptorWriteInfo& SHDescriptorWriteInfo::operator=(SHDescriptorWriteInfo&& rhs) noexcept
+  {
+    if (&rhs == this)
+      return *this;
+
+    descImageInfos = std::move(rhs.descImageInfos);
+    descBufferInfos = std::move(rhs.descBufferInfos);
+    descTexelBufferInfos = std::move(rhs.descTexelBufferInfos);
+
+    return *this;
+  }
+
+
+  SHDescriptorSetUpdater::SHDescriptorSetUpdater(SHDescriptorSetUpdater&& rhs) noexcept
+    : writeInfos{ std::move(rhs.writeInfos) }
+    , writeHashMap {std::move (rhs.writeHashMap)}
+  {
+
+  }
+
+  SHDescriptorSetUpdater::SHDescriptorSetUpdater(void) noexcept
+    : writeInfos{}
+    , writeHashMap{}
+  {
+
+  }
+
+  std::vector<vk::WriteDescriptorSet> const& SHDescriptorSetUpdater::GetWriteDescriptorSets(void) const noexcept
+  {
+    return writeDescSets;
+  }
+
+  SHDescriptorSetUpdater& SHDescriptorSetUpdater::operator=(SHDescriptorSetUpdater&& rhs) noexcept
+  {
+    if (&rhs == this)
+      return *this;
+
+    writeInfos = std::move (rhs.writeInfos);
+    writeHashMap = std::move (rhs.writeHashMap);
+
+    return *this;
+  }
+
+}

SHADE_Engine/src/Graphics/Descriptors/SHDescriptorSetUpdater.h

@@ -0,0 +1,60 @@
+#pragma once
+
+#include <vector>
+#include <unordered_map>
+#include "Graphics/SHVulkanIncludes.h"
+#include "Graphics/Shaders/SHShaderReflected.h"
+
+namespace SHADE
+{
+  // Vulkan doesn't use all of the information when looking at a writeDescriptorSet. It all 
+  // depends on the descriptor type. This struct plays it safe by having members that would
+  // accommodate all types of descriptors.
+  class SHDescriptorWriteInfo
+  {
+    //! When we want to update a descriptor that is an image, it goes in here
+    std::vector<vk::DescriptorImageInfo> descImageInfos;
+
+    //! When we want to update a descriptor that is a buffer, it goes in here
+    std::vector<vk::DescriptorBufferInfo> descBufferInfos;
+
+    //! When we want to update a descriptor that is an texel buffer, it goes in here
+    std::vector<vk::BufferView> descTexelBufferInfos;
+
+  public:
+    SHDescriptorWriteInfo (void) noexcept;
+    SHDescriptorWriteInfo (SHDescriptorWriteInfo&& rhs) noexcept;
+    SHDescriptorWriteInfo& operator= (SHDescriptorWriteInfo&& rhs) noexcept;
+
+    friend class SHVkDescriptorSetGroup;
+    friend class SHDescriptorSetUpdater;
+  };
+
+  class SHDescriptorSetUpdater
+  {
+  private:
+    //! When we want to update descriptor sets, this will get passed into vkUpdateDescriptorSets.
+    //! Each write will correspond to a binding from a set. If the binding is a variable
+    //! sized binding, pImageInfo (e.g.) will point to an array of vk::DescriptorImageInfo.
+    std::vector<SHDescriptorWriteInfo>  writeInfos;
+
+    //! When we want to update a write, we need to use this to identify the index of the write.
+    std::unordered_map<BindingAndSetHash, uint32_t> writeHashMap;
+
+    //! We keep this here because we want this to be immediately passable to vkUpdateDescriptorSets
+    std::vector<vk::WriteDescriptorSet> writeDescSets;
+
+    void LinkInfoToWriteDescSet(void) noexcept;
+
+  public:
+    SHDescriptorSetUpdater (void) noexcept;
+    SHDescriptorSetUpdater(SHDescriptorSetUpdater&& rhs) noexcept;
+    SHDescriptorSetUpdater& operator= (SHDescriptorSetUpdater&& rhs) noexcept;
+
+  public:
+    std::vector<vk::WriteDescriptorSet> const& GetWriteDescriptorSets (void) const noexcept;
+
+    friend class SHVkDescriptorSetGroup;
+  };
+}
+

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorPool.cpp

@@ -11,7 +11,7 @@ namespace SHADE
   /* Constructor/Destructor                                                          */
   /*---------------------------------------------------------------------------------*/
   SHVkDescriptorPool::SHVkDescriptorPool(Handle<SHVkLogicalDevice> device, const Config& config)
-    : device { device }
+    : device{ device }
   {
     // Create the Pool
     const vk::DescriptorPoolCreateInfo POOL_CREATE_INFO
@@ -24,12 +24,32 @@ namespace SHADE
     pool = device->GetVkLogicalDevice().createDescriptorPool(POOL_CREATE_INFO);
   }
 
+  SHVkDescriptorPool::SHVkDescriptorPool(SHVkDescriptorPool&& rhs) noexcept
+    : device{ rhs.device }
+    , pool{ rhs.pool }
+  {
+    rhs.pool = VK_NULL_HANDLE;
+  }
+
   SHVkDescriptorPool::~SHVkDescriptorPool() noexcept
   {
     if (pool)
       device->GetVkLogicalDevice().destroyDescriptorPool(pool);
   }
 
+  SHVkDescriptorPool& SHVkDescriptorPool::operator=(SHVkDescriptorPool&& rhs) noexcept
+  {
+    if (&rhs == this)
+      return *this;
+
+    device = rhs.device;
+    pool = rhs.pool;
+
+    rhs.pool = VK_NULL_HANDLE;
+
+    return *this;
+  }
+
   std::vector<Handle<SHVkDescriptorSetGroup>> SHVkDescriptorPool::Allocate(const std::vector<Handle<SHVkDescriptorSetLayout>>& layouts, std::vector<uint32_t> const& variableDescCounts)
   {
     SHVkInstance::GetResourceManager().Create<SHVkDescriptorSetGroup>(device, GetHandle(), layouts, variableDescCounts);

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorPool.h

@@ -65,7 +65,7 @@ namespace SHADE
         /// </param>
         SHVkDescriptorPool(Handle<SHVkLogicalDevice> device, const Config& config = {});
         SHVkDescriptorPool(const SHVkDescriptorPool&) = delete;
-        SHVkDescriptorPool(SHVkDescriptorPool&& rhs) noexcept = default;
+        SHVkDescriptorPool(SHVkDescriptorPool&& rhs) noexcept;
         /// <summary>
         /// Destructor which will unload and deallocate all resources for this Pool.
         /// </summary>
@@ -75,7 +75,7 @@ namespace SHADE
         /* Overloaded Operators                                                        */
         /*-----------------------------------------------------------------------------*/
         SHVkDescriptorPool& operator=(const SHVkDescriptorPool&) = delete;
-        SHVkDescriptorPool& operator=(SHVkDescriptorPool&& rhs) noexcept = default;
+        SHVkDescriptorPool& operator=(SHVkDescriptorPool&& rhs) noexcept;
 
         /*-----------------------------------------------------------------------------*/
         /* Getter Functions                                                            */

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorSetGroup.cpp

@@ -42,9 +42,11 @@ namespace SHADE
 	{
 		// Create the layout for each concurrent frame
     std::vector<vk::DescriptorSetLayout> vkLayouts{ layouts.size() };
-    for (auto& layout : layouts)
+
+    //for (auto& layout : layouts)
+    for (uint32_t i = 0; i < layouts.size(); ++i)
     {
-      vkLayouts.push_back(layout->GetVkHandle());
+      vkLayouts.push_back(layouts[i]->GetVkHandle());
     }
 
     // Check for variable descriptor count
@@ -67,6 +69,66 @@ namespace SHADE
 
     // allocate descriptor sets
     descSets = device->GetVkLogicalDevice().allocateDescriptorSets(DESC_SET_LAYOUT_CREATE_INFO);
+
+
+
+    // Now we want to prepare the write descriptor sets for writing later.
+    for (uint32_t i = 0; i < layouts.size(); ++i)
+    {
+      auto const& bindings = layouts[i]->GetBindings();
+      for (auto& binding : bindings)
+      {
+        BindingAndSetHash writeHash = binding.BindPoint;
+        writeHash |= static_cast<uint64_t>(i) << 32;
+
+        // new write for the binding
+        updater.writeInfos.emplace_back();
+        updater.writeHashMap.try_emplace(writeHash, updater.writeInfos.size() - 1);
+        auto& writeInfo = updater.writeInfos.back();
+
+        updater.writeDescSets.emplace_back();
+        auto& writeDescSet = updater.writeDescSets.back();
+
+        // Initialize info for write
+        writeDescSet.descriptorType = binding.Type;
+        writeDescSet.dstArrayElement = 0;
+        writeDescSet.dstSet = descSets[i];
+        writeDescSet.dstBinding = binding.BindPoint;
+
+        // Descriptor count for the write descriptor set. Usually this is set to 1, but if binding is variable sized, set to info passed in
+        uint32_t descriptorCount = (binding.flags & vk::DescriptorBindingFlagBits::eVariableDescriptorCount) ? variableDescCounts[i] : 1;
+        writeDescSet.descriptorCount = descriptorCount;
+
+        switch (binding.Type)
+        {
+          //case vk::DescriptorType::eSampler:
+          //case vk::DescriptorType::eSampledImage:
+        case vk::DescriptorType::eCombinedImageSampler:
+          writeInfo.descImageInfos.resize(descriptorCount);
+        break;
+        //case vk::DescriptorType::eStorageImage:
+        //  break;
+        case vk::DescriptorType::eUniformTexelBuffer:
+        case vk::DescriptorType::eStorageTexelBuffer:
+        case vk::DescriptorType::eUniformBuffer:
+        case vk::DescriptorType::eStorageBuffer:
+          writeInfo.descImageInfos.resize (descriptorCount);
+          break;
+          //case vk::DescriptorType::eUniformBufferDynamic:
+          //  break;
+          //case vk::DescriptorType::eStorageBufferDynamic:
+          //  break;
+          //case vk::DescriptorType::eInputAttachment:
+          //  break;
+          //case vk::DescriptorType::eInlineUniformBlock:
+          //  break;
+        default:
+          break;
+        }
+      }
+    }
+    // Link all the writeDescSet data for vkUpdateDescriptorSets to write to the linked descriptors
+    updater.LinkInfoToWriteDescSet();
 	}
 
   /***************************************************************************/
@@ -82,4 +144,45 @@ namespace SHADE
     if (!descSets.empty())
       device->GetVkLogicalDevice().freeDescriptorSets(descPool->GetVkHandle(), descSets);
 	}
+
+  /***************************************************************************/
+  /*! 
+   
+    \brief
+      Modifies a descriptor write info. #NoteToSelf: This function does NOT 
+      need to modify the writeDescSets. Those are already linked before.
+    
+    \param imageViewsAndSamplers
+      Image and view samplers
+   
+  */ 
+  /***************************************************************************/
+  void SHVkDescriptorSetGroup::ModifyWriteDescImage(uint32_t set, uint32_t binding, std::vector<std::pair<vk::ImageView, vk::Sampler>> const& imageViewsAndSamplers) noexcept
+  {
+    // Find the target writeDescSet
+    BindingAndSetHash writeHash = binding;
+    writeHash |= static_cast<uint64_t>(set) << 32;
+    auto& writeInfo = updater.writeInfos[updater.writeHashMap.at(writeHash)];
+
+    if (imageViewsAndSamplers.size() > writeInfo.descImageInfos.size())
+    {
+      SHLOG_ERROR("Attempting write too many descriptors into descriptor set. Failed to write to vk::WriteDescriptorSet. ");
+    }
+
+    for (uint32_t i = 0; i < imageViewsAndSamplers.size(); ++i)
+    {
+      // write sampler and image view
+      auto& ivs = imageViewsAndSamplers[i];
+      writeInfo.descImageInfos[i].imageView = ivs.first;
+      writeInfo.descImageInfos[i].sampler = ivs.second;
+    }
+  }
+
+
+  void SHVkDescriptorSetGroup::UpdateDescriptorSet(void) noexcept
+  {
+    device->UpdateDescriptorSets(updater.GetWriteDescriptorSets());
+  }
+
+
 }

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorSetGroup.h

@@ -1,8 +1,10 @@
- #pragma once
+#pragma once
 
 // Project Includes
 #include "Graphics/SHVulkanIncludes.h"
 #include "Resource/Handle.h"
+#include "Graphics/Shaders/SHShaderReflected.h"
+#include "SHDescriptorSetUpdater.h"
 
 namespace SHADE
 {
@@ -13,6 +15,7 @@ namespace SHADE
   class SHVkDescriptorPool;
   class SHVkDescriptorSetLayout;
 
+
   /*---------------------------------------------------------------------------------*/
   /* Type Definitions                                                                */
   /*---------------------------------------------------------------------------------*/
@@ -50,6 +53,12 @@ namespace SHADE
     SHVkDescriptorSetGroup& operator=(const SHVkDescriptorSetGroup&) = delete;
     SHVkDescriptorSetGroup& operator=(SHVkDescriptorSetGroup&& rhs) noexcept = default;
 
+    /*-----------------------------------------------------------------------------*/
+    /* Descriptor set writing                                                      */
+    /*-----------------------------------------------------------------------------*/
+    void ModifyWriteDescImage (uint32_t set, uint32_t binding, std::vector<std::pair<vk::ImageView, vk::Sampler>> const& imageViewsAndSamplers) noexcept;
+    void UpdateDescriptorSet (void) noexcept;
+
     /*-----------------------------------------------------------------------------*/
     /* Getter Functions                                                            */
     /*-----------------------------------------------------------------------------*/
@@ -59,13 +68,22 @@ namespace SHADE
     /// <returns>Handle to the Vulkan Descriptor Set.</returns>
     [[nodiscard]]
     inline const std::vector<vk::DescriptorSet>& GetVkHandle() { return descSets; }
-
   private:
     /*-----------------------------------------------------------------------------*/
     /* Data Members                                                                */
     /*-----------------------------------------------------------------------------*/
+    //! Device required to allocate descriptor sets
     Handle<SHVkLogicalDevice> device;
+
+    //! Descriptor pool to allocate descriptor sets 
     Handle<SHVkDescriptorPool> descPool;
+
+    //! Descriptor sets
     std::vector<vk::DescriptorSet> descSets;
+
+    //! for updating descriptor sets. We want to cache this so that we don't create the
+    //! write structs at runtime.
+    SHDescriptorSetUpdater updater;
+
   };
 }

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorSetLayout.cpp

@@ -85,6 +85,11 @@ namespace SHADE
             device->GetVkLogicalDevice().destroyDescriptorSetLayout(setLayout);
     }
 
+    std::vector<SHVkDescriptorSetLayout::Binding> const& SHVkDescriptorSetLayout::GetBindings(void) const noexcept
+    {
+      return layoutDesc;
+    }
+
     SHVkDescriptorSetLayout& SHVkDescriptorSetLayout::operator=(SHVkDescriptorSetLayout&& rhs) noexcept
     {
       if (&rhs == this)

SHADE_Engine/src/Graphics/Descriptors/SHVkDescriptorSetLayout.h

@@ -96,6 +96,7 @@ namespace SHADE
         /// </summary>
         /// <returns>Handle to the Vulkan Descriptor Set Layout handle.</returns>
         inline const vk::DescriptorSetLayout& GetVkHandle() const { return setLayout; }
+        std::vector<Binding> const&           GetBindings (void) const noexcept;
 
       private:
         /*-----------------------------------------------------------------------------*/

SHADE_Engine/src/Graphics/Devices/SHVkLogicalDevice.cpp

@@ -418,7 +418,12 @@ namespace SHADE
   /***************************************************************************/
   Handle<SHVkImage> SHVkLogicalDevice::CreateImage(uint32_t w, uint32_t h, uint8_t levels, vk::Format format, vk::ImageUsageFlags usage, vk::ImageCreateFlags create) const noexcept
   {
-    return SHVkInstance::GetResourceManager().Create<SHVkImage>(std::cref(vmaAllocator), w, h, levels, format, usage, create);
+    return SHVkInstance::GetResourceManager().Create<SHVkImage>(&vmaAllocator, w, h, levels, format, usage, create);
+  }
+
+  Handle<SHVkImage> SHVkLogicalDevice::CreateImage(SHImageCreateParams const& imageDetails, unsigned char* data, uint32_t dataSize, std::span<uint32_t> inMipOffsets, VmaMemoryUsage memUsage, VmaAllocationCreateFlags allocFlags) noexcept
+  {
+    return SHVkInstance::GetResourceManager().Create<SHVkImage>(&vmaAllocator, imageDetails, data, dataSize, inMipOffsets, memUsage, allocFlags);
   }
 
   /***************************************************************************/
@@ -509,6 +514,12 @@ namespace SHADE
 
   }
 
+  Handle<SHVkDescriptorPool> SHVkLogicalDevice::CreateDescriptorPools(const SHVkDescriptorPool::Config& config /*= {}*/) noexcept
+  {
+    return SHVkInstance::GetResourceManager().Create <SHVkDescriptorPool>(GetHandle(), config);
+
+  }
+
   /***************************************************************************/
   /*!
   
@@ -541,6 +552,22 @@ namespace SHADE
     return SHVkInstance::GetResourceManager().Create<SHVkSemaphore>(GetHandle());
   }
 
+  /***************************************************************************/
+  /*! 
+   
+    \brief
+      Writes to descriptor sets.
+    
+    \param writeDescSets
+      Descriptor sets to write to.
+   
+  */ 
+  /***************************************************************************/
+  void SHVkLogicalDevice::UpdateDescriptorSets(std::vector<vk::WriteDescriptorSet> const& writeDescSets) noexcept
+  {
+    vkLogicalDevice.updateDescriptorSets(writeDescSets, {});
+  }
+
   /***************************************************************************/
   /*!
   

SHADE_Engine/src/Graphics/Devices/SHVkLogicalDevice.h

@@ -17,8 +17,9 @@
 #include "Graphics/Pipeline/SHPipelineState.h"
 #include "Graphics/Pipeline/SHPipelineType.h"
 #include "vk_mem_alloc.h"
-//#include "Graphics/DescriptorSets/SHDescriptorPool.h"
+#include "Graphics/Descriptors/SHVkDescriptorPool.h"
 #include "Graphics/Descriptors/SHVkDescriptorSetLayout.h"
+#include "Graphics/Images/SHVkImage.h"
 
 namespace SHADE
 {
@@ -29,7 +30,6 @@ namespace SHADE
   class SHVkSurface;
   class SHVkSwapchain;
   class SHVkBuffer;
-  class SHVkImage;
   class SHVkFence;
   class SHVkSemaphore;
   class SHVkShaderModule;
@@ -38,6 +38,7 @@ namespace SHADE
   class SHVkFramebuffer;
   class SHVkImageView;
   class SHShaderBlockInterface;
+  class SHVkDescriptorSetGroup;
 
   /***************************************************************************/
   /*!
@@ -146,6 +147,15 @@ namespace SHADE
                                                                vk::ImageCreateFlags             create
                                                               ) const noexcept;
     
+    Handle<SHVkImage>               CreateImage               (
+                                                               SHImageCreateParams const&       imageDetails,
+                                                               unsigned char*                   data,
+                                                               uint32_t                         dataSize,
+                                                               std::span<uint32_t>              inMipOffsets,
+                                                               VmaMemoryUsage                   memUsage,
+                                                               VmaAllocationCreateFlags         allocFlags
+                                                              ) noexcept;
+
     Handle<SHVkShaderModule>        CreateShaderModule        (
                                                                std::vector<uint32_t> const&     binaryData, 
                                                                std::string                      entryPoint, 
@@ -165,10 +175,13 @@ namespace SHADE
     Handle<SHVkRenderpass>          CreateRenderpass          (std::span<vk::AttachmentDescription> const vkDescriptions, std::span<vk::SubpassDescription> const spDescs, std::span<vk::SubpassDependency> const spDeps) noexcept;
     Handle<SHVkFramebuffer>         CreateFramebuffer         (Handle<SHVkRenderpass> const& renderpassHdl, std::vector<Handle<SHVkImageView>> const& attachments, uint32_t inWidth, uint32_t inHeight) noexcept;
     Handle<SHVkDescriptorSetLayout> CreateDescriptorSetLayout (std::vector<SHVkDescriptorSetLayout::Binding> const& bindings) noexcept;
+    Handle<SHVkDescriptorPool>      CreateDescriptorPools     (const SHVkDescriptorPool::Config& config = {}) noexcept;
     Handle<SHVkPipelineLayout>      CreatePipelineLayout      (SHPipelineLayoutParams& pipelineLayoutParams) noexcept;
     Handle<SHVkFence>               CreateFence               (void) const noexcept;
     Handle<SHVkSemaphore>           CreateSemaphore           (void) const noexcept;
 
+    void UpdateDescriptorSets (std::vector<vk::WriteDescriptorSet> const& writeDescSets) noexcept;
+
     /*-----------------------------------------------------------------------*/
     /* SETTERS AND GETTERS                                                   */
     /*-----------------------------------------------------------------------*/

SHADE_Engine/src/Graphics/Devices/SHVkPhysicalDeviceLibrary.cpp

@@ -180,10 +180,10 @@ namespace SHADE
       return;
     }
 
-    SHLOG_ERROR("Successfully queried Physical Devices:");
+    SHLOG_TRACE("Successfully queried Physical Devices:");
     for (auto const& device : physicalDevices)
     {
-      SHLOG_ERROR(std::string_view (std::string("\t-") + GetDeviceTypeName(device.getProperties().deviceType) + device.getProperties().deviceName.operator std::string()));
+      SHLOG_TRACE(std::string_view (std::string("\t-") + GetDeviceTypeName(device.getProperties().deviceType) + device.getProperties().deviceName.operator std::string()));
     }
   }
 }

SHADE_Engine/src/Graphics/Images/SHVkImage.cpp

@@ -5,12 +5,86 @@
 #include "Tools/SHLogger.h"
 #include "SHVkImageView.h"
 #include "Graphics/Instance/SHVkInstance.h"
+#include "Graphics/Buffers/SHVkBuffer.h"
 
 namespace SHADE
 {
+  /***************************************************************************/
+  /*!
+  
+    \brief
+      If an image is a GPU only resource, we need to prep a staging buffer
+      to use for transferring data to the GPU. #NoteToSelf: I don't really
+      like this because its duplicate code. Should try to find a way to utilize
+      the logical device for this.
+    
+    \param data
+      Data to transfer.
+
+    \param srcSize
+      Size in bytes of the data.
+   
+  */
+  /***************************************************************************/
+  void SHVkImage::PrepStagingBuffer(void* data, uint32_t srcSize) noexcept
+  {
+    // For creation of buffer
+    vk::BufferCreateInfo bufferInfo{};
+
+    // size stored same as GPU buffer
+    bufferInfo.size = srcSize;
+
+    // We just want to set the transfer bit 
+    bufferInfo.usage = vk::BufferUsageFlagBits::eTransferSrc;
+
+    // sharing mode exclusive
+    bufferInfo.sharingMode = vk::SharingMode::eExclusive;
+
+    // Set to auto detect bits
+    VmaAllocationCreateInfo allocCreateInfo{};
+    allocCreateInfo.usage = VMA_MEMORY_USAGE_AUTO;
+
+    // We want to just write all at once. Using random access bit could make this slow
+    allocCreateInfo.flags = VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT;
+
+    // parameters of a vmaAllocation retrieved via vmaGetAllocationInfo
+    VmaAllocationInfo allocInfo;
+
+    // results of allocation
+    VmaAllocation stagingAlloc;
+
+    // To get around VMA's usage for C version of vulkan, create a temp first...,
+    VkBuffer tempBuffer{};
+
+    // Create the buffer...
+    vmaCreateBuffer(*vmaAllocator,
+      &bufferInfo.operator VkBufferCreateInfo & (), // TODO: Verify if this works (can use renderdoc to check buffer variables?)
+      &allocCreateInfo,
+      &tempBuffer, &stagingAlloc, &allocInfo);
+
+    // then assign it to the hpp version
+    stagingBuffer = tempBuffer;
+
+    // Just map, copy then unmap
+    void* stagingBufferMappedPtr = nullptr;
+    vmaMapMemory(*vmaAllocator, stagingAlloc, &stagingBufferMappedPtr);
+
+    if (stagingBufferMappedPtr)
+      std::memcpy(static_cast<uint8_t*>(stagingBufferMappedPtr), static_cast<uint8_t*>(data), srcSize);
+
+    const VkDeviceSize offsets = 0;
+    const VkDeviceSize sizes = srcSize;
+    vmaFlushAllocations(*vmaAllocator, 1, &stagingAlloc, &offsets, &sizes);
+
+    vmaUnmapMemory(*vmaAllocator, stagingAlloc);
+  }
+
   SHVkImage::SHVkImage(
-                       VmaAllocator const&        vmaAllocator,
+                       VmaAllocator const* allocator,
                        SHImageCreateParams const&                 imageDetails,
+                       unsigned char*                             data,
+                       uint32_t                                   dataSize,
+                       std::span<uint32_t>                        inMipOffsets,
                        VmaMemoryUsage                             memUsage,
                        VmaAllocationCreateFlags                   allocFlags
                       ) noexcept
@@ -23,12 +97,14 @@ namespace SHADE
     , imageFormat{ imageDetails.imageFormat }
     , usageFlags{}
     , createFlags{}
+    , vmaAllocator{allocator}
+    , mipOffsets { inMipOffsets }
+    , boundToCoherent{false}
+    , randomAccessOptimized {false}
+    , mappedPtr{nullptr}
   {
-    for (auto& bit : imageDetails.usageBits)
+    usageFlags = imageDetails.usageFlags;
-      usageFlags |= bit;
+    createFlags = imageDetails.createFlags;
-
-    for (auto& bit : imageDetails.createBits)
-      createFlags |= bit;
 
     // If marked as 2D array compatible, image type MUST be 3D
     if (createFlags & vk::ImageCreateFlagBits::e2DArrayCompatible)
@@ -64,58 +140,52 @@ namespace SHADE
     VmaAllocationInfo allocInfo{};
     
     VkImage tempImage;
-    vmaCreateImage(vmaAllocator, &imageCreateInfo.operator VkImageCreateInfo&(), &allocCreateInfo, &tempImage, &alloc, &allocInfo);
+    auto result = vmaCreateImage(*vmaAllocator, &imageCreateInfo.operator VkImageCreateInfo&(), &allocCreateInfo, &tempImage, &alloc, &allocInfo);
+
+    if (result != VK_SUCCESS)
+      SHVulkanDebugUtil::ReportVkError(vk::Result(result), "Failed to create vulkan image. ");
+    else
+      SHVulkanDebugUtil::ReportVkSuccess("Successfully created image. ");
+
     vkImage = tempImage;
 
-    //if (allocFlags & )
+    // At this point the image and device memory have been created. 
+
+    if (allocFlags & VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT)
+      randomAccessOptimized = true;
+
+    // TODO: This constructor can only create a GPU only resource for now. Due to time constraint, I was trying to create a ctor
+    // fast to finish up the ImGUI backend. In the future, there definitely needs to be more versatility to the constructor.
+
+    // Get the memory property flags
+    VkMemoryPropertyFlags memPropFlags;
+    vmaGetAllocationMemoryProperties(*vmaAllocator, alloc, &memPropFlags);
+
+    // mainly host visible. Can be cached (need to flush/invalidate), uncached (always coherent) and coherent (virtual). 
+    //if (memPropFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)
+    //{
+    //  // If memory is marked to be coherent between CPU and GPU (no need flush/invalidate) (TODO: Verify if VMA_ALLOCATION_CREATE_MAPPED_BIT is used when VMA_MEMORY_USAGE_AUTO is set)
+    //  // TODO: also verify that coherent bit = pointer is already mapped
+    //  if (memPropFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT)
+    //  {
+    //    boundToCoherent = true;
+    //    mappedPtr = allocInfo.pMappedData;
+    //  }
+    //  else
+    //    mappedPtr = nullptr;
+
+    //  if (data)
+    //    MapWriteUnmap(data, srcSize, 0, 0);
+    //}
+    //else
+    //{
+      // We can prep first so that we can do transfers later via 1 cmd buffer recording
+      PrepStagingBuffer(data, dataSize);
+
+    //}
   }
 
-  /***************************************************************************/
+  SHVkImage::SHVkImage(VmaAllocator const* allocator, uint32_t w, uint32_t h, uint8_t levels, vk::Format format, vk::ImageUsageFlags usage, vk::ImageCreateFlags create) noexcept
-  /*!
-  
-    \brief
-      This is mainly used for images that aren't created internally because
-      they cannot be created in the traditional way (e.g. swapchain images).
-    
-    \param inVkImage
-      Image already created outside
-      
-    \param width
-      Width of the image
-
-    \param height
-      Height of the image
-
-    \param depth
-      Depth of the image
-
-    \param levels
-      Number of levels in the image
-
-    \param arrayLayers
-      if the image is an array, this value will be > 1.
-
-    \param imageFormat
-      Format of the image
-   
-  */
-  /***************************************************************************/
-  SHVkImage::SHVkImage(vk::Image inVkImage, vk::ImageType type, uint32_t inWidth, uint32_t inHeight, uint32_t inDepth, uint32_t arrayLayers, uint8_t levels, vk::Format format, vk::ImageUsageFlags flags) noexcept
-    : vkImage (inVkImage)
-    , width{ inWidth }
-    , height{ inHeight }
-    , depth{ inDepth }
-    , mipLevelCount{ levels }
-    , layerCount{ arrayLayers }
-    , imageFormat{ format }
-    , usageFlags{flags}
-    , alloc{}
-    , imageType{type}
-    , createFlags{}
-  {
-  }
-
-  SHVkImage::SHVkImage(VmaAllocator const& vmaAllocator, uint32_t w, uint32_t h, uint8_t levels, vk::Format format, vk::ImageUsageFlags usage, vk::ImageCreateFlags create) noexcept
     : width {w}
     , height{h}
     , depth {1}
@@ -124,6 +194,7 @@ namespace SHADE
     , imageFormat{format}
     , usageFlags{usage}
     , createFlags {create}
+    , vmaAllocator {allocator}
   {
     vk::ImageCreateInfo imageCreateInfo{};
     imageCreateInfo.imageType = vk::ImageType::e2D;
@@ -149,7 +220,7 @@ namespace SHADE
     VmaAllocationInfo allocInfo{};
 
     VkImage tempImage;
-    auto result = vmaCreateImage(vmaAllocator, &imageCreateInfo.operator VkImageCreateInfo & (), &allocCreateInfo, &tempImage, &alloc, &allocInfo);
+    auto result = vmaCreateImage(*vmaAllocator, &imageCreateInfo.operator VkImageCreateInfo & (), &allocCreateInfo, &tempImage, &alloc, &allocInfo);
     vkImage = tempImage;
 
     if (result != VK_SUCCESS)
@@ -163,6 +234,86 @@ namespace SHADE
     return SHVkInstance::GetResourceManager().Create<SHVkImageView>(inLogicalDeviceHdl, parent, createParams);
   }
 
+  void SHVkImage::TransferToDeviceResource(Handle<SHVkCommandBuffer> const& cmdBufferHdl) noexcept
+  {
+    // prepare copy regions
+    std::vector<vk::BufferImageCopy> copyRegions{mipOffsets.size()};
+
+    for (uint32_t i = 0; i < mipOffsets.size(); ++i)
+    {
+      copyRegions[i].bufferOffset = mipOffsets[i];
+      copyRegions[i].bufferRowLength = 0;   // for padding
+      copyRegions[i].bufferImageHeight = 0; // for padding
+      copyRegions[i].imageSubresource.aspectMask = vk::ImageAspectFlagBits::eColor; // TODO: Need to change this to base it off image format. 
+      copyRegions[i].imageSubresource.mipLevel = i;
+      copyRegions[i].imageSubresource.baseArrayLayer = 0; // TODO: Array textures not supported yet
+      copyRegions[i].imageSubresource.layerCount = layerCount;
+      copyRegions[i].imageOffset = vk::Offset3D{ 0,0,0 };
+      copyRegions[i].imageExtent = vk::Extent3D{ width >> i, height >> i, 1 };
+    }
+
+  }
+
+  /***************************************************************************/
+  /*! 
+   
+    \brief
+      Does not perform any image transitions but prepares a barrier for image
+      transitioning. Pipeline barrier will be issued outside this call after
+      this preparation function, or at least, it should be. 
+    
+    \param oldLayout
+      Old layout of the image.
+
+    \param newLayout
+      new layout of the image to transition to.
+
+    \param barrier
+      Barrier to modify to prepare the image for transitioning.
+   
+  */ 
+  /***************************************************************************/
+  void SHVkImage::PrepareImageTransition(vk::ImageLayout oldLayout, vk::ImageLayout newLayout, vk::ImageMemoryBarrier& barrier) noexcept
+  {
+    barrier.oldLayout = oldLayout;
+    barrier.newLayout = newLayout;
+    barrier.srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
+    barrier.dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
+    barrier.image = vkImage;
+    barrier.subresourceRange.aspectMask = vk::ImageAspectFlagBits::eColor; // TODO: Need to change this to base it off image format. 
+    barrier.subresourceRange.baseMipLevel = 0;
+    barrier.subresourceRange.levelCount = mipLevelCount;
+    barrier.subresourceRange.baseArrayLayer = 0;
+    barrier.subresourceRange.layerCount = layerCount;
+
+    vk::PipelineStageFlagBits srcStage = vk::PipelineStageFlagBits::eTopOfPipe;
+    vk::PipelineStageFlagBits dstStage = vk::PipelineStageFlagBits::eTopOfPipe;
+
+    if (oldLayout == vk::ImageLayout::eUndefined && newLayout == vk::ImageLayout::eTransferDstOptimal)
+    {
+      srcStage = vk::PipelineStageFlagBits::eTopOfPipe;
+      dstStage = vk::PipelineStageFlagBits::eTransfer;
+
+      barrier.srcAccessMask = vk::AccessFlagBits::eNone;
+      barrier.dstAccessMask = vk::AccessFlagBits::eTransferWrite;
+    }
+    else if (oldLayout == vk::ImageLayout::eTransferDstOptimal && newLayout == vk::ImageLayout::eShaderReadOnlyOptimal)
+    {
+      srcStage = vk::PipelineStageFlagBits::eTransfer;
+
+      // TODO, what if we want to access in compute shader
+      dstStage = vk::PipelineStageFlagBits::eFragmentShader;
+
+      barrier.srcAccessMask = vk::AccessFlagBits::eTransferWrite;
+      barrier.dstAccessMask = vk::AccessFlagBits::eShaderRead;
+    }
+    else
+    {
+      SHLOG_ERROR("Image layouts are invalid. ");
+    }
+
+  }
+
   void SHVkImage::LinkWithExteriorImage(vk::Image inVkImage, vk::ImageType type, uint32_t inWidth, uint32_t inHeight, uint32_t inDepth, uint32_t layers, uint8_t levels, vk::Format format, vk::ImageUsageFlags flags) noexcept
   {
     vkImage = inVkImage;

SHADE_Engine/src/Graphics/Images/SHVkImage.h

@@ -10,6 +10,7 @@ namespace SHADE
 {
   class SHVkLogicalDevice;
   class SHVkImageView;
+  class SHVkCommandBuffer;
 
   struct SHImageCreateParams
   {
@@ -35,10 +36,10 @@ namespace SHADE
     vk::Format                         imageFormat;
 
     //! Image usage bits
-    std::span<vk::ImageUsageFlagBits>  usageBits;
+    vk::ImageUsageFlags                usageFlags;
 
     //! Image create flags
-    std::span<vk::ImageCreateFlagBits> createBits;
+    vk::ImageCreateFlags               createFlags;
   };
 
   class SHVkImage
@@ -47,6 +48,12 @@ namespace SHADE
     /*-----------------------------------------------------------------------*/
     /* PRIVATE MEMBER VARIABLES                                              */
     /*-----------------------------------------------------------------------*/
+    //! Pointer to the vma allocator. #NoteToSelf: Not super proud of this being a pointer.
+    //! The only reason why this is a pointer is because a reference_wrapper cannot be default constructed.
+    //! And the reason why we want a default constructor is because sometimes we don't want to create images
+    //! but merely link them from outside (swapchain images)
+    VmaAllocator const* vmaAllocator;
+
     //! 1D, 2D or 3D
     vk::ImageType        imageType = vk::ImageType::e2D;
 
@@ -80,22 +87,46 @@ namespace SHADE
     //! allocation object containing details of an allocation
     VmaAllocation alloc{};
 
+    //! Whether or not this image is HOST_VISIBLE and random access optimized
+    bool randomAccessOptimized;
+
+    //! Whether or not the memory the image is bound to is memory coherent (updates on CPU can be seen on GPU without flushing cache)
+    bool boundToCoherent;
+
+    //! Persistently mapped pointer if applicable (will be void if image is
+    //! not created with the correct flags). Note that this is only used for
+    //! persistent mapping. One time updates do not use this pointer.
+    void* mappedPtr;
+
+    //! Staging buffer for images purely in the GPU
+    vk::Buffer stagingBuffer;
+
+    //! Mipmap offsets for initializing the vk::BufferImageCopy during transfer to GPU resource
+    std::span<uint32_t> mipOffsets;
+
+    /*-----------------------------------------------------------------------*/
+    /* PRIVATE MEMBER FUNCTIONS                                              */
+    /*-----------------------------------------------------------------------*/
+    void PrepStagingBuffer(void* data, uint32_t srcSize) noexcept;
+
+
   public:
     /*-----------------------------------------------------------------------*/
     /* CTOR AND DTOR                                                         */
     /*-----------------------------------------------------------------------*/
     SHVkImage(void) noexcept = default;
 
-    // TODO: Might need to add flags to parameters
     SHVkImage(
-              VmaAllocator const&         vmaAllocator,
+              VmaAllocator const*                        allocator,
               SHImageCreateParams const&                 imageDetails,
+              unsigned char*                             data,
+              uint32_t                                   dataSize,
+              std::span<uint32_t>                        inMipOffsets,
               VmaMemoryUsage                             memUsage,
               VmaAllocationCreateFlags                   allocFlags
              ) noexcept;
 
-    SHVkImage(vk::Image inVkImage, vk::ImageType type, uint32_t inWidth, uint32_t inHeight, uint32_t inDepth, uint32_t arrayLayers, uint8_t levels, vk::Format format, vk::ImageUsageFlags flags) noexcept;
+    SHVkImage(VmaAllocator const* allocator, uint32_t w, uint32_t h, uint8_t levels, vk::Format format, vk::ImageUsageFlags usage, vk::ImageCreateFlags create) noexcept;
-    SHVkImage(VmaAllocator const& vmaAllocator, uint32_t w, uint32_t h, uint8_t levels, vk::Format format, vk::ImageUsageFlags usage, vk::ImageCreateFlags create) noexcept;
 
     SHVkImage(SHVkImage&& rhs) noexcept = default;
     SHVkImage& operator=(SHVkImage && rhs) noexcept = default;
@@ -103,7 +134,9 @@ namespace SHADE
     /*-----------------------------------------------------------------------*/
     /* PUBLIC MEMBER FUNCTIONS                                               */
     /*-----------------------------------------------------------------------*/
-    Handle<SHVkImageView> CreateImageView(Handle<SHVkLogicalDevice> const& inLogicalDeviceHdl, Handle<SHVkImage> const& parent, SHImageViewDetails const& createParams) const noexcept;
+    Handle<SHVkImageView> CreateImageView          (Handle<SHVkLogicalDevice> const& inLogicalDeviceHdl, Handle<SHVkImage> const& parent, SHImageViewDetails const& createParams) const noexcept;
+    void                  TransferToDeviceResource (Handle<SHVkCommandBuffer> const& cmdBufferHdl) noexcept;
+    void                  PrepareImageTransition   (vk::ImageLayout oldLayout, vk::ImageLayout newLayout, vk::ImageMemoryBarrier& barrier) noexcept;
 
     /*-----------------------------------------------------------------------*/
     /* GETTERS AND SETTERS                                                   */

SHADE_Engine/src/Graphics/Images/SHVkSampler.cpp

@@ -0,0 +1,7 @@
+#include "SHpch.h"
+#include "SHVkSampler.h"
+
+namespace SHADE
+{
+  
+}

SHADE_Engine/src/Graphics/Images/SHVkSampler.h

@@ -0,0 +1,27 @@
+#pragma once
+
+#include "Graphics/SHVulkanIncludes.h"
+
+namespace SHADE
+{
+  struct SHVkSamplerParams
+  {
+    vk::Filter minFilter;
+    vk::Filter maxFilter;
+    //vk::Filter maxFilter;
+  };
+
+  class SHVkSampler
+  {
+  private:
+    //! The vulkan sampler handler
+    vk::Sampler vkSampler;
+  	
+  public:
+    SHVkSampler   () noexcept;
+    SHVkSampler   (SHVkSampler&& rhs) noexcept;
+    SHVkSampler&& operator=(SHVkSampler&& rhs) noexcept;
+
+  };
+}
+

SHADE_Engine/src/Graphics/MiddleEnd/Interface/SHGraphicsSystem.cpp

@@ -22,14 +22,12 @@ of DigiPen Institute of Technology is prohibited.
 
 namespace SHADE
 {
+
   /*---------------------------------------------------------------------------------*/
 	/* Constructor/Destructors                                                         */
 	/*---------------------------------------------------------------------------------*/
-	SHGraphicsSystem::SHGraphicsSystem(SHWindow& window)
+	void SHGraphicsSystem::Init(void)
 	{
-		// Save the SHWindow
-		this->window = &window;
-
 		// Set Up Instance
 		SHVkInstance::Init(true, true, true);
 
@@ -39,10 +37,10 @@ namespace SHADE
 		device = SHVkInstance::CreateLogicalDevice({ SHQueueParams(SH_Q_FAM::GRAPHICS, SH_QUEUE_SELECT::DEDICATED), SHQueueParams(SH_Q_FAM::TRANSFER, SH_QUEUE_SELECT::DEDICATED) }, physicalDevice);
 
 		// Construct surface
-		surface = device->CreateSurface(window.GetHWND());
+		surface = device->CreateSurface(window->GetHWND());
 
 		// Construct Swapchain
-		auto windowDims = window.GetWindowSize();
+		auto windowDims = window->GetWindowSize();
 		swapchain = device->CreateSwapchain(surface, windowDims.first, windowDims.second, SHSwapchainParams
 		{
 			.surfaceImageFormats {vk::Format::eB8G8R8A8Unorm, vk::Format::eR8G8B8A8Unorm, vk::Format::eB8G8R8Unorm, vk::Format::eR8G8B8Unorm},
@@ -51,13 +49,13 @@ namespace SHADE
 			.vsyncOn = false,    // TODO: Set to true when shipping game
 		});
 
-		window.RegisterWindowSizeCallback([&]([[maybe_unused]] uint32_t width, [[maybe_unused]] uint32_t height)
+		window->RegisterWindowSizeCallback([&]([[maybe_unused]] uint32_t width, [[maybe_unused]] uint32_t height)
 		{
 			renderContext.SetIsResized(true);
 		});
 
 		// Create graphics queue
-		queue = device->GetQueue(SH_Q_FAM::GRAPHICS, 0);
+		graphicsQueue = device->GetQueue(SH_Q_FAM::GRAPHICS, 0);
 		
 
 		// Create Render Context
@@ -87,7 +85,7 @@ namespace SHADE
 			//commandBuffers[i] = commandPool->RequestCommandBuffer(SH_CMD_BUFFER_TYPE::PRIMARY); // works
 		}
 
-
+		descPool = device->CreateDescriptorPools();
 
 
 
@@ -101,12 +99,12 @@ namespace SHADE
     renderGraph.AddResource("Composite", SH_ATT_DESC_TYPE::COLOR, windowDims.first, windowDims.second, vk::Format::eR16G16B16A16Sfloat);
     renderGraph.AddResource("Downscale", SH_ATT_DESC_TYPE::COLOR, windowDims.first, windowDims.second, vk::Format::eR16G16B16A16Sfloat);
     renderGraph.AddResource("Present", SH_ATT_DESC_TYPE::COLOR_PRESENT, windowDims.first, windowDims.second);
-		auto node = renderGraph.AddNode("G-Buffer", { "Position", "Normals", "Composite" }, {}); // no predecessors
+		auto node = renderGraph.AddNode("G-Buffer", { "Composite", "Position", "Normals", "Present" }, {}); // no predecessors
 		
 		// First subpass to write to G-Buffer
     auto writeSubpass = node->AddSubpass("G-Buffer Write");
     writeSubpass->AddColorOutput("Position");
-    writeSubpass->AddColorOutput("Normals");
+    writeSubpass->AddColorOutput("Present");
 
 		// Second subpass to read from G-Buffer
 		auto compositeSubpass = node->AddSubpass("G-Buffer Composite");
@@ -114,11 +112,11 @@ namespace SHADE
     compositeSubpass->AddInput("Normals");
     compositeSubpass->AddInput("Position");
 
-		auto compositeNode = renderGraph.AddNode("Bloom", { "Composite", "Downscale", "Present"}, {"G-Buffer"});
+    //auto compositeNode = renderGraph.AddNode("Bloom", { "Composite", "Downscale", "Present" }, { "G-Buffer" });
-		auto bloomSubpass = compositeNode->AddSubpass("Downsample");
+    //auto bloomSubpass = compositeNode->AddSubpass("Downsample");
-		bloomSubpass->AddInput("Composite");
+    //bloomSubpass->AddInput("Composite");
-    bloomSubpass->AddColorOutput("Downscale");
+    //bloomSubpass->AddColorOutput("Downscale");
-    bloomSubpass->AddColorOutput("Present");
+    //bloomSubpass->AddColorOutput("Present");
 
 		renderGraph.Generate();
 
@@ -127,11 +125,25 @@ namespace SHADE
 		/* RENDERGRAPH END TESTING                                               */
 		/*-----------------------------------------------------------------------*/
 	}
-	SHGraphicsSystem::~SHGraphicsSystem()
+
+  void SHGraphicsSystem::Run(float dt) noexcept
+  {
+    auto const& frameData = renderContext.GetCurrentFrameData();
+
+    renderGraph.Execute(renderContext.GetCurrentFrame());
+
+    graphicsQueue->SubmitCommandBuffer({ renderGraph.GetCommandBuffer(renderContext.GetCurrentFrame()) },
+      { frameData.semRenderFinishHdl },
+      { frameData.semImgAvailableHdl },
+      vk::PipelineStageFlagBits::eColorAttachmentOutput | vk::PipelineStageFlagBits::eEarlyFragmentTests | vk::PipelineStageFlagBits::eLateFragmentTests);
+
+  }
+
+  void SHGraphicsSystem::Exit(void)
 	{
 		//renderPass.Free();
 		renderContext.Destroy();
-		queue.Free();
+		graphicsQueue.Free();
 		swapchain.Free();
 		surface.Free();
 		device.Free();
@@ -205,7 +217,7 @@ namespace SHADE
 		presentInfo.pImageIndices = &CURR_FRAME_IDX;
 
 		// #BackEndTest: queues an image for presentation
-		if (auto result = device->GetQueue(SH_Q_FAM::GRAPHICS, 0)->GetVkQueue().presentKHR(&presentInfo); result != vk::Result::eSuccess)
+		if (auto result = graphicsQueue->Present(swapchain, {currFrameData.semRenderFinishHdl}, CURR_FRAME_IDX); result != vk::Result::eSuccess)
 		{
 			// If swapchain is incompatible/outdated
 			if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR)
@@ -235,4 +247,19 @@ namespace SHADE
 	void SHGraphicsSystem::RemoveSegment(Handle<SHScreenSegment> segment)
 	{
 	}
+
+  void SHGraphicsSystem::SetWindow(SHWindow* wind) noexcept
+  {
+		window = wind;
+  }
+
+  SHRenderGraph const& SHGraphicsSystem::GetRenderGraph(void) const noexcept
+  {
+		return renderGraph;
+  }
+
+  void SHGraphicsSystem::SHGraphicsSystemRoutine::Execute(double dt) noexcept
+  {
+  }
+
 }

SHADE_Engine/src/Graphics/MiddleEnd/Interface/SHGraphicsSystem.h

@@ -21,9 +21,14 @@ of DigiPen Institute of Technology is prohibited.
 #include "Graphics/SHVulkanIncludes.h"
 #include "Graphics/MiddleEnd/PerFrame/SHRenderContext.h"
 #include "Graphics/RenderGraph/SHRenderGraph.h"
+#include "ECS_Base/System/SHSystem.h"
+#include "ECS_Base/System/SHSystemRoutine.h"
+#include "Graphics/Descriptors/SHVkDescriptorPool.h"
 
 namespace SHADE
 {
+	
+
 	/*---------------------------------------------------------------------------------*/
 	/* Forward Declarations                                                            */
 	/*---------------------------------------------------------------------------------*/
@@ -61,8 +66,15 @@ namespace SHADE
 		portions of the screen.
 	*/
 	/***********************************************************************************/
-	class SHGraphicsSystem
+	class SH_API SHGraphicsSystem : public SHSystem
 	{
+	public:
+    class SH_API SHGraphicsSystemRoutine : public SHSystemRoutine
+    {
+    public:
+      virtual void Execute(double dt) noexcept override;
+    };
+
 	  public:
 		/*-----------------------------------------------------------------------------*/
 		/* Constants                                                                   */
@@ -72,8 +84,15 @@ namespace SHADE
 		/*-----------------------------------------------------------------------------*/
 		/* Constructor/Destructors                                                     */
 		/*-----------------------------------------------------------------------------*/
-		SHGraphicsSystem(SHWindow& window);
+		SHGraphicsSystem (void) = default;
-		~SHGraphicsSystem();
+		~SHGraphicsSystem(void) noexcept = default;
+
+		/*-----------------------------------------------------------------------------*/
+		/* SHSystem overrides                                                          */
+		/*-----------------------------------------------------------------------------*/
+		virtual void Init(void) override;
+		void Run (float dt) noexcept;
+		virtual void Exit(void) override;
 
 		/*-----------------------------------------------------------------------------*/
 		/* Lifecycle Functions                                                         */
@@ -93,12 +112,22 @@ namespace SHADE
 		Handle<SHScreenSegment> AddSegment(const VkViewport& viewport, Handle<SHVkImage> imageToUse);
 		void RemoveSegment(Handle<SHScreenSegment> segment);
 
+		/*-----------------------------------------------------------------------------*/
+		/* Setters                                                                     */
+		/*-----------------------------------------------------------------------------*/
+		void SetWindow (SHWindow* wind) noexcept;
+
 		/*-----------------------------------------------------------------------------*/
 		/* Getters (Temporary)                                                         */
 		/*-----------------------------------------------------------------------------*/
 		Handle<SHVkLogicalDevice> GetDevice() const { return device; }
 		Handle<SHVkSwapchain> GetSwapchain() const { return swapchain; }
 		Handle<SHVkSurface> GetSurface() const { return surface; }
+		Handle<SHVkPhysicalDevice> GetPhysicalDevice() const {return physicalDevice;}
+    Handle<SHVkQueue> GetQueue() const { return graphicsQueue; }
+    Handle<SHVkDescriptorPool> GetDescriptorPool() const { return descPool; }
+		SHRenderGraph const& GetRenderGraph (void) const noexcept;
+
 		//Handle<SHVkRenderpass> GetRenderPass() const { return renderPass; }
 
 
@@ -111,7 +140,8 @@ namespace SHADE
 		Handle<SHVkLogicalDevice>                                 device;
 		Handle<SHVkSurface>                                       surface;
 		Handle<SHVkSwapchain>                                     swapchain;
-		Handle<SHVkQueue>                                         queue;
+		Handle<SHVkQueue>                                         graphicsQueue;
+		Handle<SHVkDescriptorPool>																descPool;
 		//Handle<SHVkRenderpass>                                    renderPass; // Potentially bring out?
 		std::vector<SHScreenSegment>                              screenSegments;
 		SHRenderContext                                           renderContext;
@@ -125,5 +155,6 @@ namespace SHADE
 		//std::vector<SHRenderer> renderers;
 		SHRenderGraph renderGraph;
 
+		friend SHGraphicsSystemRoutine;
 	};
 }

SHADE_Engine/src/Graphics/MiddleEnd/PerFrame/SHRenderContext.h

@@ -3,6 +3,7 @@
 
 #include <vector>
 #include "SHPerFrameData.h"
+#include "SH_API.h"
 
 namespace SHADE
 {
@@ -16,7 +17,7 @@ namespace SHADE
   //! render context in SHADE engine has is that it requires users to call these explicitly in the middle end. While there 
   //! is little reason the flow of the render context should deviate from its intended usage, we want to leave it up to
   //! users to explicitly call functions from here so we don't risk losing opportunities for different usage.  
-  class SHRenderContext
+  class SH_API SHRenderContext
   {
   private:
     //! container of frame data. Note that the manager owns the data, but the frame data themselves do not own anything. 

SHADE_Engine/src/Graphics/Pipeline/SHPipelineState.cpp

@@ -117,7 +117,7 @@ namespace SHADE
     dirty = isDirty;
   }
 
-  std::tuple<uint32_t, uint32_t, vk::Format> SHVertexInputState::GetInfoFromAttribFormat(SHAttribFormat attribFormat) const noexcept
+  std::tuple<SHVertexInputState::numAttribSlots, SHVertexInputState::bytesRequired, vk::Format> SHVertexInputState::GetInfoFromAttribFormat(SHAttribFormat attribFormat) const noexcept
   {
     switch (attribFormat)
     {
@@ -138,6 +138,9 @@ namespace SHADE
     case SHAttribFormat::MAT_4D:
       return std::make_tuple(4, 16, vk::Format::eR32G32B32A32Sfloat);
       break;
+
+    case SHAttribFormat::UINT32_1D:
+      return std::make_tuple(1, 4, vk::Format::eR32Uint);
     }
     return std::make_tuple(0, 0, vk::Format::eR32Sfloat);
   }

SHADE_Engine/src/Graphics/Queues/SHVkQueue.cpp

@@ -5,6 +5,7 @@
 #include "Graphics/Synchronization/SHVkSemaphore.h"
 #include "Graphics/Synchronization/SHVkFence.h"
 #include "Graphics/Commands/SHVkCommandBuffer.h"
+#include "Graphics/Swapchain/SHVkSwapchain.h"
 
 
 namespace SHADE
@@ -31,14 +32,10 @@ namespace SHADE
 
   }
 
-  vk::Queue SHVkQueue::GetVkQueue(void) const noexcept
+  void SHVkQueue::SubmitCommandBuffer(std::initializer_list<Handle<SHVkCommandBuffer>> cmdBuffers, std::initializer_list<Handle<SHVkSemaphore>> signalSems /*= {}*/, std::initializer_list<Handle<SHVkSemaphore>> waitSems /*= {}*/, vk::PipelineStageFlags waitDstStageMask /*= {}*/, Handle<SHVkFence> const& optionalFence /*= {}*/) noexcept
   {
-    return vkQueue;
+    // prepare wait sems
-  }
+    std::array<vk::Semaphore, 5> vkWaitSems{ };
-
-  void SHVkQueue::SubmitCommandBuffer(std::initializer_list<Handle<SHVkCommandBuffer>> cmdBuffers, std::initializer_list<Handle<SHVkSemaphore>> signalSems /*= {}*/, std::initializer_list<Handle<SHVkSemaphore>> waitSems /*= {}*/, vk::PipelineStageFlagBits waitDstStageMask /*= {}*/, Handle<SHVkFence> const& optionalFence /*= {}*/) noexcept
-  {
-    std::vector<vk::Semaphore> vkWaitSems{ waitSems.size() };
     uint32_t i = 0;
     for (auto& sem : waitSems)
     {
@@ -46,7 +43,8 @@ namespace SHADE
       ++i;
     }
 
-    std::vector<vk::Semaphore> vkSignalSems{ signalSems.size() };
+    // prepare signal sems
+    std::array<vk::Semaphore, 5> vkSignalSems{ };
     i = 0;
     for (auto& sem : signalSems)
     {
@@ -54,33 +52,76 @@ namespace SHADE
       ++i;
     }
 
-    std::vector<vk::CommandBuffer> vkCmdBuffers{ cmdBuffers.size() };
+    // prepare cmd buffers
+    std::array<vk::CommandBuffer, 5> vkCmdBuffers{ };
     i = 0;
     for (auto& cmdBuffer : cmdBuffers)
     {
+      // Check if command buffer is in executable state
+      if (!cmdBuffer->IsReadyToSubmit())
+      {
+        SHLOG_ERROR("Command buffer is not in executable state. Cannot submit command buffer. ");
+        return;
+      }
+
       vkCmdBuffers[i] = cmdBuffer->GetVkCommandBuffer();
       ++i;
     }
 
-    vk::PipelineStageFlags mask = waitDstStageMask;
+    // Prepare submit info
-
     vk::SubmitInfo submitInfo
     {
-      .waitSemaphoreCount = static_cast<uint32_t>(vkWaitSems.size()),
+      .waitSemaphoreCount = static_cast<uint32_t>(waitSems.size()),
       .pWaitSemaphores = vkWaitSems.data(),
-      .pWaitDstStageMask = &mask,
+      .pWaitDstStageMask = &waitDstStageMask,
-      .commandBufferCount = static_cast<uint32_t>(vkCmdBuffers.size()),
+      .commandBufferCount = static_cast<uint32_t>(cmdBuffers.size()),
       .pCommandBuffers = vkCmdBuffers.data(),
-      .signalSemaphoreCount = static_cast<uint32_t>(vkSignalSems.size()),
+      .signalSemaphoreCount = static_cast<uint32_t>(signalSems.size()),
       .pSignalSemaphores = vkSignalSems.data(),
     };
 
-    // #BackEndTest: Submit the queue
+    // Submit the queue
     if (auto result = vkQueue.submit(1, &submitInfo, (optionalFence) ? optionalFence->GetVkFence() : nullptr); result != vk::Result::eSuccess)
     {
       SHVulkanDebugUtil::ReportVkError(result, "Failed to submit command buffer. ");
     }
+    else // if success
+    {
+      // Change all command buffers to pending state
+      for (Handle<SHVkCommandBuffer> cmdBuffer : cmdBuffers)
+      {
+        cmdBuffer->HandlePostSubmit();
+      }
+    }
+  }
 
+  vk::Result SHVkQueue::Present(Handle<SHVkSwapchain> const& swapchain, std::initializer_list<Handle<SHVkSemaphore>> waitSems, uint32_t frameIndex) noexcept
+  {
+    vk::PresentInfoKHR presentInfo{};
+
+    // prepare wait sems
+    std::array<vk::Semaphore, 5> vkWaitSems{ };
+    uint32_t i = 0;
+    for (auto& sem : waitSems)
+    {
+      vkWaitSems[i] = sem->GetVkSem();
+      ++i;
+    }
+
+    // prepare presentation information
+    presentInfo.waitSemaphoreCount = static_cast<uint32_t>(waitSems.size());
+    presentInfo.pWaitSemaphores = vkWaitSems.data();
+    presentInfo.swapchainCount = 1;
+    presentInfo.pSwapchains = &swapchain->GetVkSwapchain();
+    presentInfo.pImageIndices = &frameIndex;
+
+    // Present swapchain image.
+    auto result = vkQueue.presentKHR(&presentInfo);
+    if (result != vk::Result::eSuccess)
+    {
+      SHLOGV_ERROR ("Failed to present swapchain image. ");
+    }
+    return result;
   }
 
 }

SHADE_Engine/src/Graphics/Queues/SHVkQueue.h

@@ -11,6 +11,7 @@ namespace SHADE
   class SHVkCommandBuffer;
   class SHVkFence;
   class SHVkSemaphore;
+  class SHVkSwapchain;
 
   enum class SH_QUEUE_FAMILY_ARRAY_INDEX : std::size_t
   {
@@ -45,9 +46,9 @@ namespace SHADE
 
   public:
     SHVkQueue(vk::Queue inVkQueue, SHQueueFamilyIndex parent, Handle<SHVkLogicalDevice> const& inLogicalDeviceHdl) noexcept;
-    vk::Queue GetVkQueue(void) const noexcept;
 
-    void SubmitCommandBuffer(std::initializer_list<Handle<SHVkCommandBuffer>> cmdBuffers, std::initializer_list<Handle<SHVkSemaphore>> signalSems = {}, std::initializer_list<Handle<SHVkSemaphore>> waitSems = {}, vk::PipelineStageFlagBits waitDstStageMask = {}, Handle<SHVkFence> const& fence = {}) noexcept;
+    void       SubmitCommandBuffer (std::initializer_list<Handle<SHVkCommandBuffer>> cmdBuffers, std::initializer_list<Handle<SHVkSemaphore>> signalSems = {}, std::initializer_list<Handle<SHVkSemaphore>> waitSems = {}, vk::PipelineStageFlags waitDstStageMask = {}, Handle<SHVkFence> const& fence = {}) noexcept;
+    vk::Result Present             (Handle<SHVkSwapchain> const& swapchain, std::initializer_list<Handle<SHVkSemaphore>> waitSems, uint32_t frameIndex) noexcept;
   };
 }
 

SHADE_Engine/src/Graphics/RenderGraph/SHRenderGraph.cpp

@@ -209,9 +209,10 @@ namespace SHADE
 
   */
   /***************************************************************************/
-  SHRenderGraphNode::SHSubpass::SHSubpass(std::unordered_map<uint64_t, uint32_t> const* mapping, std::unordered_map<std::string, Handle<SHRenderGraphResource>> const* resources) noexcept
+  SHRenderGraphNode::SHSubpass::SHSubpass(Handle<SHRenderGraphNode> const& parent, std::unordered_map<uint64_t, uint32_t> const* mapping, std::unordered_map<std::string, Handle<SHRenderGraphResource>> const* resources) noexcept
     : resourceAttachmentMapping{ mapping }
     , ptrToResources{ resources }
+    , parentNode{ parent }
   {
 
   }
@@ -333,6 +334,38 @@ namespace SHADE
     inputReferences.push_back({ resourceAttachmentMapping->at(ptrToResources->at(resourceToReference).GetId().Raw), vk::ImageLayout::eShaderReadOnlyOptimal });
   }
 
+  void SHRenderGraphNode::SHSubpass::Execute(Handle<SHVkCommandBuffer>& commandBuffer) noexcept
+  {
+    // Draw all the batches
+
+    // Draw all the exterior draw calls
+    for (auto& drawCall : exteriorDrawCalls)
+    {
+      drawCall(commandBuffer);
+    }
+  }
+
+  void SHRenderGraphNode::SHSubpass::AddExteriorDrawCalls(std::function<void(Handle<SHVkCommandBuffer>&)> const& newDrawCall) noexcept
+  {
+    exteriorDrawCalls.push_back(newDrawCall);
+  }
+
+  /***************************************************************************/
+  /*!
+
+    \brief
+      Getter for parent renderpass.
+
+    \return
+      Returns the parent renderpass the subpass belongs to.
+
+  */
+  /***************************************************************************/
+  Handle<SHRenderGraphNode> const& SHRenderGraphNode::SHSubpass::GetParentNode(void) const noexcept
+  {
+    return parentNode;
+  }
+
   /***************************************************************************/
   /*!
 
@@ -426,10 +459,10 @@ namespace SHADE
       // We set this to clear first. If later we find out that some predecessor is writing to the same attachment, 
       // we set the pred's storeOp to eStore and "this" loadOp to eLoad.
       newDesc.loadOp = vk::AttachmentLoadOp::eClear;
-      newDesc.storeOp = vk::AttachmentStoreOp::eDontCare;
+      newDesc.storeOp = vk::AttachmentStoreOp::eStore;
 
       newDesc.stencilLoadOp = vk::AttachmentLoadOp::eClear;
-      newDesc.stencilStoreOp = vk::AttachmentStoreOp::eDontCare;
+      newDesc.stencilStoreOp = vk::AttachmentStoreOp::eStore;
 
       newDesc.format = attResources[i]->resourceFormat;
 
@@ -512,11 +545,44 @@ namespace SHADE
     }
 
     // Add subpass to container and create mapping for it
-    subpasses.emplace_back(resourceManager.Create<SHSubpass>(&resourceAttachmentMapping, ptrToResources));
+    subpasses.emplace_back(resourceManager.Create<SHSubpass>(GetHandle(), &resourceAttachmentMapping, ptrToResources));
-    subpassIndexing.try_emplace(subpassName, subpasses.size() - 1);
+    subpassIndexing.try_emplace(subpassName, static_cast<uint32_t>(subpasses.size()) - 1u);
     return subpasses.at(subpassIndexing[subpassName]);
   }
 
+  void SHRenderGraphNode::Execute(Handle<SHVkCommandBuffer>& commandBuffer, uint32_t frameIndex) noexcept
+  {
+    frameIndex = (framebuffers.size() > 1) ? frameIndex : 0;
+    commandBuffer->BeginRenderpass(renderpass, framebuffers[frameIndex]);
+
+    for (uint32_t i = 0; i < subpasses.size(); ++i)
+    {
+      subpasses[i]->Execute(commandBuffer);
+
+      // Go to next subpass if not last subpass
+      if (i != subpasses.size() - 1)
+        commandBuffer->NextSubpass();
+    }
+
+    commandBuffer->EndRenderpass();
+  }
+
+  /***************************************************************************/
+  /*!
+
+    \brief
+      Get the renderpass from the node.
+
+    \return
+      Handle to the renderpass.
+
+  */
+  /***************************************************************************/
+  Handle<SHVkRenderpass> SHRenderGraphNode::GetRenderpass(void) const noexcept
+  {
+    return renderpass;
+  }
+
   /***************************************************************************/
   /*!
 
@@ -544,7 +610,7 @@ namespace SHADE
 
   */
   /***************************************************************************/
-  void SHRenderGraph::AddResource(std::string resourceName, SH_ATT_DESC_TYPE type, uint32_t w /*= static_cast<uint32_t>(-1)*/, uint32_t h /*= static_cast<uint32_t>(-1)*/, vk::Format format/* = vk::Format::eB8G8R8A8Unorm*/, uint32_t levels /*= 1*/, vk::ImageCreateFlagBits createFlags /*= {}*/)
+  void SHRenderGraph::AddResource(std::string resourceName, SH_ATT_DESC_TYPE type, uint32_t w /*= static_cast<uint32_t>(-1)*/, uint32_t h /*= static_cast<uint32_t>(-1)*/, vk::Format format/* = vk::Format::eB8G8R8A8Unorm*/, uint8_t levels /*= 1*/, vk::ImageCreateFlagBits createFlags /*= {}*/)
   {
     // If we set to 
     if (w == static_cast<uint32_t>(-1) && h == static_cast<uint32_t>(-1))
@@ -816,6 +882,24 @@ namespace SHADE
     }
   }
 
+  /***************************************************************************/
+  /*!
+
+    \brief
+      Configures command pools and command buffers.
+
+  */
+  /***************************************************************************/
+  void SHRenderGraph::ConfigureCommands(void) noexcept
+  {
+    commandPool = logicalDeviceHdl->CreateCommandPool(SH_QUEUE_FAMILY_ARRAY_INDEX::GRAPHICS, SH_CMD_POOL_RESET::POOL_BASED, true);
+    commandBuffers.resize(static_cast<std::size_t>(swapchainHdl->GetNumImages()));
+    for (auto& cmdBuffer : commandBuffers)
+    {
+    	cmdBuffer = commandPool->RequestCommandBuffer(SH_CMD_BUFFER_TYPE::PRIMARY);
+    }
+  }
+
   /***************************************************************************/
   /*!
 
@@ -913,7 +997,7 @@ namespace SHADE
     }
 
     nodes.emplace_back(resourceManager.Create<SHRenderGraphNode>(resourceManager, logicalDeviceHdl, swapchainHdl, std::move(resources), std::move(predecessors), &graphResources));
-    nodeIndexing.emplace(nodeName, nodes.size() - 1);
+    nodeIndexing.emplace(nodeName, static_cast<uint32_t>(nodes.size()) - 1u);
     return nodes.at(nodeIndexing[nodeName]);
   }
 
@@ -936,6 +1020,37 @@ namespace SHADE
     ConfigureSubpasses();
     ConfigureRenderpasses();
     ConfigureFramebuffers();
+    ConfigureCommands();
+  }
+
+  void SHRenderGraph::Execute(uint32_t frameIndex) noexcept
+  {
+    commandPool->Reset();
+
+    auto& cmdBuffer = commandBuffers[frameIndex];
+    cmdBuffer->BeginRecording();
+
+    cmdBuffer->SetviewportScissor(1920.0f, 1080.0f, 1920, 1080);
+
+    for (auto& node : nodes)
+    {
+      node->Execute(commandBuffers[frameIndex], frameIndex);
+    }
+
+    cmdBuffer->EndRecording();
+  }
+
+  Handle<SHRenderGraphNode> SHRenderGraph::GetNode(std::string const& nodeName) const noexcept
+  {
+    if (nodeIndexing.contains(nodeName))
+      return nodes[nodeIndexing.at(nodeName)];
+
+    return {};
+  }
+
+  Handle<SHVkCommandBuffer> const& SHRenderGraph::GetCommandBuffer(uint32_t frameIndex) const noexcept
+  {
+    return commandBuffers[frameIndex];
   }
 
 }

SHADE_Engine/src/Graphics/RenderGraph/SHRenderGraph.h

@@ -3,6 +3,7 @@
 
 #include "Graphics/Renderpass/SHVkRenderpass.h"
 #include "Resource/ResourceLibrary.h"
+#include "SH_API.h"
 
 #include <string>
 #include <map>
@@ -15,6 +16,8 @@ namespace SHADE
   class SHVkImage;
   class SHVkImageView;
   class SHVkFramebuffer;
+  class SHVkCommandPool;
+  class SHVkCommandBuffer;
 
   // Used for attachment description creation for renderpass node
   enum class SH_ATT_DESC_TYPE
@@ -26,7 +29,7 @@ namespace SHADE
     DEPTH_STENCIL,
   };
 
-  class SHRenderGraphResource
+  class SH_API SHRenderGraphResource
   {
   private:
     /*-----------------------------------------------------------------------*/
@@ -72,25 +75,44 @@ namespace SHADE
     friend class SHRenderGraph;
   };
 
-  class SHRenderGraphNode
+  class SH_API SHRenderGraphNode : public ISelfHandle<SHRenderGraphNode>
   {
   public:
 
-    class SHSubpass
+    class SH_API SHSubpass
     {
     public:
-      SHSubpass(std::unordered_map<uint64_t, uint32_t> const* mapping, std::unordered_map<std::string, Handle<SHRenderGraphResource>> const* ptrToResources) noexcept;
+      /*-----------------------------------------------------------------------*/
+      /* CTORS AND DTORS                                                       */
+      /*-----------------------------------------------------------------------*/
+      SHSubpass(Handle<SHRenderGraphNode> const& parent, std::unordered_map<uint64_t, uint32_t> const* mapping, std::unordered_map<std::string, Handle<SHRenderGraphResource>> const* ptrToResources) noexcept;
       SHSubpass(SHSubpass&& rhs) noexcept;
       SHSubpass& operator=(SHSubpass&& rhs) noexcept;
 
+      /*-----------------------------------------------------------------------*/
+      /* PUBLIC MEMBER FUNCTIONS                                               */
+      /*-----------------------------------------------------------------------*/
+      // Preparation functions
       void AddColorOutput (std::string resourceToReference) noexcept;
       void AddDepthOutput (std::string resourceToReference, SH_ATT_DESC_TYPE attachmentDescriptionType = SH_ATT_DESC_TYPE::DEPTH_STENCIL) noexcept;
       void AddInput       (std::string resourceToReference) noexcept;
       
+      // Runtime functions
+      void Execute              (Handle<SHVkCommandBuffer>& commandBuffer) noexcept;
+      void AddExteriorDrawCalls (std::function<void(Handle<SHVkCommandBuffer>&)> const& newDrawCall) noexcept;
+      
+      /*-----------------------------------------------------------------------*/
+      /* GETTERS AND SETTERS                                                   */
+      /*-----------------------------------------------------------------------*/
+      Handle<SHRenderGraphNode> const& GetParentNode (void) const noexcept;
+
     private:
       /*---------------------------------------------------------------------*/
       /* PRIVATE MEMBER VARIABLES                                            */
       /*---------------------------------------------------------------------*/
+      //! The parent renderpass that this subpass belongs to
+      Handle<SHRenderGraphNode>            parentNode;
+
       //! Color attachments
       std::vector<vk::AttachmentReference> colorReferences;
 
@@ -106,6 +128,14 @@ namespace SHADE
       //! Pointer to resources in the render graph (for getting handle IDs)
       std::unordered_map<std::string, Handle<SHRenderGraphResource>> const* ptrToResources;
 
+      //! Sometimes there exists entities that we want to render onto a render target
+      //! but don't want it to come from the batching system. An example would be ImGUI.
+      //! For these entities we want to link a function from the outside and draw them 
+      //! after we draw everything from the batch. Because of this, these draw calls
+      //! are always the last things drawn, so DO NOT USE THIS FUNCTIONALITY FOR ANYTHING 
+      //! COMPLEX.
+      std::vector<std::function<void(Handle<SHVkCommandBuffer>&)>> exteriorDrawCalls; 
+
       friend class SHRenderGraphNode;
       friend class SHRenderGraph;
     };
@@ -179,11 +209,17 @@ namespace SHADE
     /* PUBLIC MEMBER FUNCTIONS                                               */
     /*-----------------------------------------------------------------------*/
     Handle<SHSubpass> AddSubpass (std::string subpassName) noexcept;
+    void Execute (Handle<SHVkCommandBuffer>& commandBuffer, uint32_t frameIndex) noexcept;
+
+    /*-----------------------------------------------------------------------*/
+    /* SETTERS AND GETTERS                                                   */
+    /*-----------------------------------------------------------------------*/
+    Handle<SHVkRenderpass> GetRenderpass (void) const noexcept;
 
     friend class SHRenderGraph;
   };
 
-  class SHRenderGraph
+  class SH_API SHRenderGraph
   {
   private:
     /*-----------------------------------------------------------------------*/
@@ -193,6 +229,7 @@ namespace SHADE
     void ConfigureSubpasses              (void) noexcept;
     void ConfigureRenderpasses           (void) noexcept;
     void ConfigureFramebuffers           (void) noexcept;
+    void ConfigureCommands               (void) noexcept;
 
     /*-----------------------------------------------------------------------*/
     /* PRIVATE MEMBER VARIABLES                                              */
@@ -214,6 +251,13 @@ namespace SHADE
     //! Resource library for graph handles
     ResourceManager resourceManager;
 
+    //! Command pool for the render graph
+    Handle<SHVkCommandPool> commandPool;
+
+    //! Command buffers for the render graph
+    std::vector<Handle<SHVkCommandBuffer>> commandBuffers;
+    
+
   public:
     /*-----------------------------------------------------------------------*/
     /* CTORS AND DTORS                                                       */
@@ -224,9 +268,16 @@ namespace SHADE
     /* PUBLIC MEMBER FUNCTIONS                                               */
     /*-----------------------------------------------------------------------*/
     void                      Init        (Handle<SHVkLogicalDevice> const& logicalDevice, Handle<SHVkSwapchain> const& swapchain) noexcept;
-    void                      AddResource(std::string resourceName, SH_ATT_DESC_TYPE type, uint32_t w = static_cast<uint32_t>(-1), uint32_t h = static_cast<uint32_t>(-1), vk::Format format = vk::Format::eB8G8R8A8Unorm, uint32_t levels = 1, vk::ImageCreateFlagBits createFlags = {});
+    void                      AddResource (std::string resourceName, SH_ATT_DESC_TYPE type, uint32_t w = static_cast<uint32_t>(-1), uint32_t h = static_cast<uint32_t>(-1), vk::Format format = vk::Format::eB8G8R8A8Unorm, uint8_t levels = 1, vk::ImageCreateFlagBits createFlags = {});
     Handle<SHRenderGraphNode> AddNode     (std::string nodeName, std::initializer_list<std::string> resourceNames, std::initializer_list<std::string> predecessorNodes) noexcept;
     void                      Generate    (void) noexcept;
+    void                      Execute     (uint32_t frameIndex) noexcept;
+
+    /*-----------------------------------------------------------------------*/
+    /* SETTERS AND GETTERS                                                   */
+    /*-----------------------------------------------------------------------*/
+    Handle<SHRenderGraphNode> GetNode                 (std::string const& nodeName) const noexcept;
+    Handle<SHVkCommandBuffer> const& GetCommandBuffer (uint32_t frameIndex) const noexcept;
   };
 }
 

SHADE_Engine/src/Graphics/Renderpass/SHVkRenderpass.cpp

@@ -29,11 +29,17 @@ namespace SHADE
   /***************************************************************************/
   SHVkRenderpass::SHVkRenderpass(Handle<SHVkLogicalDevice> const& inLogicalDeviceHdl, std::span<vk::AttachmentDescription> const vkDescriptions, std::vector<SHVkSubpassParams> const& subpasses) noexcept
     : logicalDeviceHdl {inLogicalDeviceHdl}
+    , numAttDescs {static_cast<uint32_t>(vkDescriptions.size())}
     , clearColors{}
   {
-    // TODO: temporary only
+    for (uint32_t i = 0; i < vkDescriptions.size(); ++i)
-    clearColors[0].color = { {{0.0f, 0.0f, 0.0f, 1.0f}} };
+    {
-    clearColors[1].depthStencil = vk::ClearDepthStencilValue(1.0f, 0);
+      if (SHVkUtil::IsDepthStencilAttachment(vkDescriptions[i].format))
+        clearColors[i].depthStencil = vk::ClearDepthStencilValue(1.0f, 0);
+      else
+        clearColors[i].color = { {{0.0f, 0.0f, 0.0f, 1.0f}} };
+    }
+
 
     vk::RenderPassCreateInfo renderPassCreateInfo{};
     std::vector<vk::SubpassDependency>  subpassDeps;
@@ -164,11 +170,16 @@ namespace SHADE
 
   SHVkRenderpass::SHVkRenderpass(Handle<SHVkLogicalDevice> const& inLogicalDeviceHdl, std::span<vk::AttachmentDescription> const vkDescriptions, std::span<vk::SubpassDescription> const spDescs, std::span<vk::SubpassDependency> const spDeps) noexcept
     : logicalDeviceHdl{ inLogicalDeviceHdl }
+    , numAttDescs{ static_cast<uint32_t>(vkDescriptions.size()) }
     , clearColors{}
   {
-    // TODO: temporary only
+    for (uint32_t i = 0; i < vkDescriptions.size(); ++i)
-    clearColors[0].color = { {{0.0f, 0.0f, 0.0f, 1.0f}} };
+    {
-    clearColors[1].depthStencil = vk::ClearDepthStencilValue(1.0f, 0);
+      if (SHVkUtil::IsDepthStencilAttachment(vkDescriptions[i].format))
+        clearColors[i].depthStencil = vk::ClearDepthStencilValue(1.0f, 0);
+      else
+        clearColors[i].color = { {{0.0f, 0.0f, 0.0f, 1.0f}} };
+    }
 
     subpassDescriptions.resize (spDescs.size());
     for (uint32_t i = 0; i < subpassDescriptions.size(); ++i)

SHADE_Engine/src/Graphics/Renderpass/SHVkRenderpass.h

@@ -17,7 +17,7 @@ namespace SHADE
     /*-----------------------------------------------------------------------*/
     /* STATIC CONSTEXPR VALUES                                               */
     /*-----------------------------------------------------------------------*/
-    static constexpr uint32_t NUM_CLEAR_COLORS = 2;
+    static constexpr uint32_t NUM_CLEAR_COLORS = 10;
 
     /*-----------------------------------------------------------------------*/
     /* PRIVATE MEMBER VARIABLES                                              */
@@ -34,6 +34,9 @@ namespace SHADE
     //! Clear colors for the color and depth
     std::array<vk::ClearValue, NUM_CLEAR_COLORS> clearColors;
 
+    // number of attachment descriptions
+    uint32_t numAttDescs;
+
   public:
     /*-----------------------------------------------------------------------*/
     /* CTOR AND DTOR                                                         */

SHADE_Engine/src/Graphics/Shaders/SHShaderReflected.cpp

@@ -189,7 +189,7 @@ namespace SHADE
 
   Handle<SHShaderBlockInterface> SHShaderDescriptorBindingInfo::GetShaderBlockInterface(uint32_t set, uint32_t binding) const noexcept
   {
-    SHShaderDescriptorBindingInfo::BindingAndSetHash hash = binding;
+    BindingAndSetHash hash = binding;
     hash |= static_cast<uint64_t>(set) << 32;
     if (blockInterfaces.contains(hash))
       return blockInterfaces.at(hash);

SHADE_Engine/src/Graphics/Shaders/SHShaderReflected.h

@@ -9,11 +9,10 @@
 
 namespace SHADE
 {
-  struct SHShaderDescriptorBindingInfo
-  {
-  public:
   using BindingAndSetHash = uint64_t;
 
+  struct SHShaderDescriptorBindingInfo
+  {
   private:
     /*-----------------------------------------------------------------------*/
     /* PRIVATE MEMBER VARIABLES                                              */

SHADE_Engine/src/Graphics/Swapchain/SHVkSwapchain.cpp

@@ -19,11 +19,15 @@ namespace SHADE
     vkPresentModes = physicalDeviceHdl->GetVkPhysicalDevice().getSurfacePresentModesKHR(surfaceHdl->GetVkSurface());
 
     if (vkSurfaceFormats.size() == 0)
+    {
       SHLOG_ERROR("Failed to get surface formats from the physical device. ");
+    }
 
     if (vkPresentModes.size() == 0)
+    {
       SHLOG_ERROR("Failed to get present modes from the physical device. ");
     }
+  }
 
   vk::SurfaceFormatKHR SHVkSwapchain::ChooseSwapSurfaceFormat(std::vector<vk::SurfaceFormatKHR> const& surfaceFormats) const noexcept
   {

SHADE_Engine/src/Graphics/VertexDescriptors/SHVertexAttribute.h

@@ -18,7 +18,10 @@ namespace SHADE
     // that a mat2 can be interpreted as (x, y, x, y), (o, o, o, o) instead of (x, y, o, o), (o, o, o, o)?
     MAT_2D,
     MAT_3D,
-    MAT_4D
+    MAT_4D,
+
+    // integer formats
+    UINT32_1D,
   };
 
   struct SHVertexAttribute

SHADE_Engine/src/Graphics/Windowing/SHWindow.cpp

@@ -222,7 +222,7 @@ namespace SHADE
       return true;
     {
       MSG Message;
-      while (PeekMessageW(&Message, NULL, 0, 0, PM_REMOVE))
+      while (PeekMessageW(&Message, wndHWND, 0, 0, PM_REMOVE))
       {
         if (WM_QUIT == Message.message)
         {

SHADE_Engine/src/Resource/Handle.h

@@ -139,7 +139,7 @@ namespace SHADE
         /*-----------------------------------------------------------------------------*/
         /* Data Members                                                                */
         /*-----------------------------------------------------------------------------*/
-        ResourceLibrary<T>* library;
+        ResourceLibrary<T>* library = nullptr;
         
         /*-----------------------------------------------------------------------------*/
         /* Friend Declarations                                                         */

SHADE_Engine/src/Resource/ResourceLibrary.h

@@ -69,7 +69,7 @@ namespace SHADE
         /* Helper Functions                                                            */
         /*-----------------------------------------------------------------------------*/
         void assertHandleValid(Handle<T>  handle) const;
-		int getAvailableFreeIndex();
+		uint32_t getAvailableFreeIndex();
     };
 
     /// <summary>

SHADE_Engine/src/Resource/ResourceLibrary.hpp

@@ -35,13 +35,13 @@ namespace SHADE
         }
         else
         {
-            handle.id.Data.Version = 0;
+            handle.id.Data.Version = 0U;
-            versionCounts.insert(handle.id.Data.Index, handle.id.Data.Version);
+            versionCounts.insert(static_cast<uint32_t>(handle.id.Data.Index), handle.id.Data.Version);
         }
         handle.library = this;
 
         // Create the resource
-        [[maybe_unused]] T& obj = objects.insert(handle.id.Data.Index, std::forward<Args>(args) ...);
+        [[maybe_unused]] T& obj = objects.insert(static_cast<uint32_t>(handle.id.Data.Index), std::forward<Args>(args) ...);
 
         // Handling SelfHandle assignment
         if constexpr (std::is_base_of_v<ISelfHandle<T>, T>)
@@ -89,7 +89,7 @@ namespace SHADE
     }
 
     template<typename T>
-    inline int ResourceLibrary<T>::getAvailableFreeIndex()
+    inline uint32_t ResourceLibrary<T>::getAvailableFreeIndex()
     {
         // Get from the free list if present
         if (!freeList.empty())

SHADE_Engine/src/Resource/SparseSet.hpp

@@ -56,7 +56,7 @@ namespace SHADE
             throw std::invalid_argument("An element at this index does not exist!");
 
         // Swap with the last element
-        const int BACK_IDX = denseArray.size() - 1;
+        const auto BACK_IDX = denseArray.size() - 1;
         std::swap(denseArray[sparseArray[idx]], denseArray.back());
         denseArray.pop_back();
         // Update the sparse set by swapping the indices
@@ -110,7 +110,7 @@ namespace SHADE
         // We need to resize the array
         if (idx >= sparseArray.size())
         {
-            const int NEW_SIZE = idx + 1;
+            const auto NEW_SIZE = idx + 1;
             sparseArray.resize(NEW_SIZE, INVALID);
             inverseSparseArray.resize(NEW_SIZE, INVALID);
         }
@@ -123,7 +123,7 @@ namespace SHADE
         auto& insertedElem = denseArray.emplace_back(std::forward<Args>(args) ...);
 
         // Update sparse and inverse sparse arrays
-        const index_type DENSE_IDX = denseArray.size() - 1;
+        const auto DENSE_IDX = static_cast<index_type>(denseArray.size()) - 1;
         sparseArray[idx] = DENSE_IDX;
         inverseSparseArray[DENSE_IDX] = idx;