From ef0ff801e499d80f6c594940dea66ac0eceaafe1 Mon Sep 17 00:00:00 2001
From: maverickdgg <danielcyc38@gmail.com>
Date: Sun, 5 Mar 2023 10:55:39 +0800
Subject: [PATCH 1/2] Camera arm target offset rotation fix

---
 SHADE_Engine/src/Camera/SHCameraSystem.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/SHADE_Engine/src/Camera/SHCameraSystem.cpp b/SHADE_Engine/src/Camera/SHCameraSystem.cpp
index 85f3b1b1..20d44201 100644
--- a/SHADE_Engine/src/Camera/SHCameraSystem.cpp
+++ b/SHADE_Engine/src/Camera/SHCameraSystem.cpp
@@ -272,6 +272,13 @@ namespace SHADE
         if (arm->isActive == true)
         {
           camera.offset = arm->GetOffset();
+
+          SHVec3 tOffset = arm->GetTargetOffset();
+
+          
+          tOffset = SHVec3::RotateY(tOffset, SHMath::DegreesToRadians(arm->GetYaw()));
+
+
           if (arm->lookAtCameraOrigin)
             CameraLookAt(camera, camera.position + arm->GetTargetOffset());
 

From 24f09ab5372bddf8f753f76409812069c9de2377 Mon Sep 17 00:00:00 2001
From: Kah Wei <msntkw@msn.com>
Date: Sun, 5 Mar 2023 12:17:19 +0800
Subject: [PATCH 2/2] Fixed issue with ImGui corrupting strings passed to
 managed data.

---
 SHADE_Engine/src/Editor/SHEditorUI.cpp | 2 +-
 SHADE_Managed/src/Utility/Convert.cxx  | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/SHADE_Engine/src/Editor/SHEditorUI.cpp b/SHADE_Engine/src/Editor/SHEditorUI.cpp
index b9783020..45cf0f6c 100644
--- a/SHADE_Engine/src/Editor/SHEditorUI.cpp
+++ b/SHADE_Engine/src/Editor/SHEditorUI.cpp
@@ -308,7 +308,7 @@ namespace SHADE
     const bool CHANGED = ImGui::InputText("##", &buffer[0], TEXT_FIELD_MAX_LENGTH);
     if (CHANGED)
     {
-      value = std::string(buffer.data(), buffer.data() + TEXT_FIELD_MAX_LENGTH);
+      value = std::string(buffer.data(), buffer.data() + std::strlen(buffer.data()));
     }
     return CHANGED;
   }
diff --git a/SHADE_Managed/src/Utility/Convert.cxx b/SHADE_Managed/src/Utility/Convert.cxx
index 590a3cf0..4ff5dd43 100644
--- a/SHADE_Managed/src/Utility/Convert.cxx
+++ b/SHADE_Managed/src/Utility/Convert.cxx
@@ -91,12 +91,17 @@ namespace SHADE
     {
         if (str == nullptr)
             return "";
-        return msclr::interop::marshal_as<std::string>(str);
+        std::string s = msclr::interop::marshal_as<std::string>(str);
+        s.substr(0, str->Length);
+        return s;
     }
 
     System::String^ Convert::ToCLI(const std::string& str)
     {
-        return msclr::interop::marshal_as<System::String^>(str);
+        if (str.empty())
+            return "";
+
+        return msclr::interop::marshal_as<System::String^>(str)->Substring(0, str.length());
     }
 
     /*---------------------------------------------------------------------------------*/